Page MenuHomePhabricator

PageForms uses deprecated hooks LinkEnd
Closed, ResolvedPublic


PHP Deprecated: Use of LinkEnd hook (used in PFFormLinker::setBrokenLink) was deprecated in MediaWiki 1.28. [Called from Hooks::run in /www/ at line 202] in /www/ on line 309

Event Timeline

Nikerabbit created this task.

@Nikerabbit - thanks for letting me know about this. It would be easy to change the code to use "HtmlPageLinkRendererEnd" instead of "LinkEnd", but then Page Forms would no longer support MediaWiki versions below 1.28 (notably 1.27, the current LTS version). I could have both hooks, but it wouldn't be good for both to be called. Is there some easy way to check for the existence of the "HtmlPageLinkRendererEnd" hook, so that the function called by "LinkEnd" can exit out right away if the other hook exists?

As far as I know the only option at this case is to do version_compare against $wgVersion.

Looking at you could also do class_exists( 'LinkRenderer' ) which was added in the same commit.

Vvjjkkii renamed this task from PageForms uses deprecated hooks LinkEnd to w0aaaaaaaa.Jul 1 2018, 1:04 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Yaron_Koren as the assignee of this task.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Oetterer renamed this task from w0aaaaaaaa to PageForms uses deprecated hooks LinkEnd.Jul 1 2018, 6:06 AM
Oetterer closed this task as Resolved.
Oetterer assigned this task to Yaron_Koren.
Oetterer updated the task description. (Show Details)
Oetterer added a subscriber: Aklapper.

@Yaron_Koren Are you planning a new release anytime soon that would include this fix?

Yes - Page Forms 4.4, which I'm planning to coincide with the end of the Google Summer of Code, because a big part of the new version will be a current GSoC project.