Maniphest T197231

[BUG] Swiping a single "In the news" card off the feed should not disable the card in 'Customize the feed' screen
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	RHo
	Jun 14 2018, 11:22 AM

Description

Steps to Reproduce:

Open the feed and go to the 'Customize the feed' to ensure that "In the news" is switched ON
Return to the feed and swipe right on the In the news card to hide it.
Go back to the "Customize the feed" screen.

Actual Results:
"In the news" is shown toggled off.
See demo of this bug at: https://youtu.be/1617hJ_qgPw

Expected Results:
"In the news" should remain toggled on, since only the single instance of that card was swiped off.
Potentially related issue T150967

Occurring on
Pixel 2 (8.1) using Wikipedia v2-7-234-alpha-2018-06-12

Details

	Subject	Repo	Branch	Lines +/-
	Follow-up: correctly hide individual instances of News cards.	apps/android/wikipedia	master	+2 -24
	Fix: Swiping a single "In the news" card off the feed should not disable the card in 'Customize the feed' screen	apps/android/wikipedia	master	+20 -4

Customize query in gerrit

Related Objects

Mentioned Here: T150967: Feed news content should appear daily

Event Timeline

RHo created this task.Jun 14 2018, 11:22 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2018, 11:22 AM

RHo updated the task description. (Show Details)Jun 14 2018, 11:31 AM

cooltey claimed this task.Jun 14 2018, 11:19 PM

cooltey edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly); removed Wikipedia-Android-App-Backlog.

cooltey moved this task from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.

Change 440490 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Swiping a single "In the news" card off the feed should not disable the card in 'Customize the feed' screen

https://gerrit.wikimedia.org/r/440490

gerritbot added a project: Patch-For-Review.Jun 14 2018, 11:26 PM

Change 441079 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Follow-up: correctly hide individual instances of News cards.

https://gerrit.wikimedia.org/r/441079

Change 440490 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Swiping a single "In the news" card off the feed should not disable the card in 'Customize the feed' screen

https://gerrit.wikimedia.org/r/440490

Dbrant moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.Jun 19 2018, 8:58 PM

Change 441079 merged by jenkins-bot:
[apps/android/wikipedia@master] Follow-up: correctly hide individual instances of News cards.

https://gerrit.wikimedia.org/r/441079

Working for me on 2.7.235-alpha-2018-06-25. Sending @RHo for review

• Charlotte moved this task from Design signoff to Ready for signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.Jun 26 2018, 7:49 PM

Dbrant closed this task as Resolved.Jun 27 2018, 8:04 PM

• Vvjjkkii renamed this task from [BUG] Swiping a single "In the news" card off the feed should not disable the card in 'Customize the feed' screen to o0aaaaaaaa.Jul 1 2018, 1:03 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed cooltey as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii edited subscribers, added: cooltey; removed: gerritbot, Aklapper.

CommunityTechBot renamed this task from o0aaaaaaaa to [BUG] Swiping a single "In the news" card off the feed should not disable the card in 'Customize the feed' screen.Jul 2 2018, 6:48 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot claimed this task.

CommunityTechBot reassigned this task from CommunityTechBot to cooltey.

CommunityTechBot raised the priority of this task from High to Needs Triage.