| RHo | |
| Jun 14 2018, 12:03 PM |
| F22226205: Screenshot_1528977487.png | |
| Jun 14 2018, 12:03 PM |
Missed removing this subheading when the Offline Library feature was shelved.
Go to the app's settings screen and scroll down to the 'About' section of the app.
The subheading "Experimental" which used to appear over the experimental Offline Library setting should no longer be shown (since the Offline Library has already been removed).
The subheading "Experimental" is still shown, appearing just before the "About" subheading.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove the "Experimental" preferences subtitle | apps/android/wikipedia | master | +0 -5 |
Change 440344 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[apps/android/wikipedia@master] Remove the "Experimental" preferences subtitle
https://phabricator.wikimedia.org/diffusion/APAW/browse/master/?grep=experimental
I have removed the title from app/src/main/java/org/wikipedia/settings/SettingsPreferenceLoader.java but as you can see the string is translated to several languages. Do you want those removed too?
Thanks for submitting the patch to the Gerrit!
It it good to keep the string and remove the code from SettingsPreferenceLoader.java, just like what you did in the patch you've submitted.
Will go to +2 the patch and merge it.
Change 440344 merged by jenkins-bot:
[apps/android/wikipedia@master] Remove the "Experimental" preferences subtitle