Page MenuHomePhabricator
Create Task
Maniphest T197259

Create an API module to allow apps to read global preferences
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Discussion: T196314: UniversalLanguageSelector doesn't work if language is set globally in global preferences

Deliverables:

  • API module to allow apps to see if global preferences is enabled and to read preference values if so.

Details

SubjectRepoBranchLines +/-
Add an API module to read global prefs/local overridesmediawiki/extensions/GlobalPreferencesmaster+285 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Niharika created this task.Jun 14 2018, 6:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2018, 6:48 PM
• Niharika added a parent task: T16950: [Epic] Support global preferences on Wikimedia wikis.Jun 14 2018, 6:50 PM
MusikAnimal subscribed.Jun 14 2018, 7:11 PM

See also T62856. In my opinion we should support setting global preferences too via the API, to be consistent with the other APIs in MediaWiki.

• Niharika added a comment.Jun 14 2018, 7:47 PM
In T197259#4283817, @MusikAnimal wrote:

See also T62856. In my opinion we should support setting global preferences too via the API, to be consistent with the other APIs in MediaWiki.

Ah, thanks for pointing out that task. I was a bit hesitant about allowing global prefs to be set using the API but I think the benefits outweigh the potential concerns. I'll repurpose that ticket for supporting setting global prefs via API.

• Niharika mentioned this in T62856: Create an API module to allow apps to set global preference.Jun 14 2018, 7:49 PM
• Niharika mentioned this in T197260: Create an API module to allow apps to set local exceptions.Jun 18 2018, 5:54 PM
• Niharika set the point value for this task to 3.Jun 26 2018, 11:24 PM
• Niharika moved this task from Needs Discussion to Up Next (May 6-17) on the Community-Tech board.
• Niharika edited projects, added Community-Tech-Sprint; removed Community-Tech.Jun 26 2018, 11:44 PM
MaxSem claimed this task.Jun 26 2018, 11:48 PM
MaxSem moved this task from Ready to In Development on the Community-Tech-Sprint board.
• Niharika mentioned this in T198273: Create an API module to allow apps to read local overrides .Jun 27 2018, 12:22 AM
gerritbot subscribed.Jun 28 2018, 8:56 PM

Change 442983 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Add an API module to read global prefs/local overrides

https://gerrit.wikimedia.org/r/442983

gerritbot added a project: Patch-For-Review.Jun 28 2018, 8:56 PM
MaxSem moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Jun 28 2018, 8:56 PM
• Vvjjkkii renamed this task from Create an API module to allow apps to read global preferences to wzaaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii removed MaxSem as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii edited subscribers, added: MaxSem; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from wzaaaaaaaa to Create an API module to allow apps to read global preferences .Jul 2 2018, 6:38 AM
CommunityTechBot assigned this task to MaxSem.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot set the point value for this task to 3.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: MaxSem.
Samwilson subscribed.Jul 5 2018, 3:08 AM

So did we resolve how to treat the array-type preference values (i.e. email-blacklist and echo-notification-blacklist)? It sort of seems to make sense to match what core does (i.e. return as arrays, rather than newline-delimited strings), but I know that's more complexity and probably not going to be used anyway.

The above patch looks good and is ready to merge apart from this question, I think.

gerritbot added a comment.Jul 6 2018, 3:58 AM

Change 442983 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Add an API module to read global prefs/local overrides

https://gerrit.wikimedia.org/r/442983

• Niharika closed this task as Resolved.Jul 6 2018, 4:49 PM
• Niharika moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
In T197259#4398544, @Samwilson wrote:

So did we resolve how to treat the array-type preference values (i.e. email-blacklist and echo-notification-blacklist)? It sort of seems to make sense to match what core does (i.e. return as arrays, rather than newline-delimited strings), but I know that's more complexity and probably not going to be used anyway.

The above patch looks good and is ready to merge apart from this question, I think.

Being tackled in T198935: Clean up the mess with one-off transformations for some preferences.

• Niharika moved this task from Q1 2018-19 to Archive on the Community-Tech-Sprint board.Jul 11 2018, 7:01 PM
• Niharika added a project: Community-Tech.Jul 27 2018, 9:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL