Page MenuHomePhabricator
Create Task
Maniphest T197261

Undefined variable: mappings in extensions/ExternalData/ED_ParserFunctions.php on line 535
Closed, ResolvedPublic
Actions

Description

When creating a new website page on Wikiapiary, right after saving, I got this messages at the very top of the page:

Notice: Undefined variable: mappings in /srv/www/mediawiki/public_html/w/extensions/ExternalData/ED_ParserFunctions.php on line 535
Warning: Invalid argument supplied for foreach() in /srv/www/mediawiki/public_html/w/extensions/ExternalData/ED_ParserFunctions.php on line 535

If I reload the page I don't get them again.

Event Timeline

Ciencia_Al_Poder created this task.Jun 14 2018, 7:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2018, 7:21 PM
Kghbln added subscribers: Yaron_Koren, Kghbln.Jun 18 2018, 2:26 PM

@Yaron_Koren FYI since I am not sure if you see this.

Yaron_Koren added a comment.Jun 18 2018, 2:54 PM

@Kghbln - thanks; no, I didn't see it before.

@Ciencia_Al_Poder - there have been a bunch of changes to the ED code; I would recommend upgrading to the latest code. (And that also reminds me that I need to release a new version of ED - it's well overdue.)

• Vvjjkkii renamed this task from Undefined variable: mappings in extensions/ExternalData/ED_ParserFunctions.php on line 535 to uzaaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from uzaaaaaaaa to Undefined variable: mappings in extensions/ExternalData/ED_ParserFunctions.php on line 535.Jul 2 2018, 6:36 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Samwilson subscribed.Jul 5 2018, 12:16 AM

This is still happening, e.g.: https://wikiapiary.com/w/index.php?title=Sails_of_Care&oldid=4657503

Yaron_Koren added a comment.Jul 5 2018, 2:49 AM

@Samwilson - I still think it might be just a matter of them needing to upgrade External Data to the latest code...

Samwilson added a comment.Jul 5 2018, 2:58 AM

Yes, true.

DeepBlue subscribed.Jul 9 2018, 4:07 PM

Currently we are running version 1.8.3 of ExternalData. Is there a more recent version of this extension that I should be aware of?

Yaron_Koren added a comment.Jul 9 2018, 7:56 PM

No, but there have been a lot of changes since 1.8.3 was released (two years ago!). You should just get the latest code, if possible. That reminds me again that I need to release a new version of ED.

DeepBlue added a comment.Jul 10 2018, 4:23 PM
In T197261#4409498, @Yaron_Koren wrote:

No, but there have been a lot of changes since 1.8.3 was released (two years ago!). You should just get the latest code, if possible. That reminds me again that I need to release a new version of ED.

Where is that code?

Aklapper added a comment.Jul 11 2018, 10:01 AM

https://www.mediawiki.org/wiki/Extension:ExternalData links to it? :)

DeepBlue added a comment.Jul 11 2018, 3:13 PM

I think I'm just missing something here. Should I be cloning it from git?

Yaron_Koren added a comment.Jul 12 2018, 4:07 AM

You can do that, or download the code here (select the "master" version):

https://www.mediawiki.org/wiki/Special:ExtensionDistributor/ExternalData

DeepBlue added a comment.Jul 12 2018, 7:46 PM

Thanks. This fix is implemented and I will see if this fixes the problem. Being an intermittent issue, please give me a heads up if you see the error.

Samwilson added a comment.Jul 12 2018, 11:25 PM

Looks good!

It wasn't intermittent for me: just on a normal page view it'd only happen if the page was not cached.

DeepBlue closed this task as Resolved.Jul 19 2018, 7:40 PM
DeepBlue claimed this task.

This error no longer appears to be an issue as I have cleared the cache of multiple pages during testing of stat graphs and never encountered this.

Ciencia_Al_Poder reopened this task as Open.Jul 23 2018, 9:28 AM

The issue hasn't been resolved. I've just created a new page and the error appears again at the top of the page:

imagen.png (364×1 px, 43 KB)

Notice: Undefined variable: mappings in /srv/www/mediawiki/public_html/w/extensions/ExternalData/includes/ED_ParserFunctions.php on line 540
Warning: Invalid argument supplied for foreach() in /srv/www/mediawiki/public_html/w/extensions/ExternalData/includes/ED_ParserFunctions.php on line 540

However, it only appears right after creating the page. If I reload the page the error is not displayed.

The line number is now different, though.

DeepBlue added a comment.Jul 23 2018, 3:08 PM

Hmm...interesting. Will see what I can do.

DeepBlue closed this task as Resolved.Aug 16 2018, 6:13 PM

We now check if the variable mappings is set before running the snippet of code on 540. This should resolve this problem.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL