Page MenuHomePhabricator
Create Task
Maniphest T197271

PHPUnit fails on PHP 7.1 and HHVM 3.18 (1 failure: McrRevisionStoreDbTest)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

https://travis-ci.org/wikimedia/mediawiki/jobs/392321537

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/416465/ / T174024

The builds were passing before this commit and started failing after it.

There was 1 failure:
1) MediaWiki\Tests\Storage\McrRevisionStoreDbTest::testInsertRevisionOn_successes with data set "Multi-slot revision insertion" (array(array(WikitextContent Object (...), TextContent Object (...)), true, CommentStoreComment Object (...), '20171117010101', true))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'main'
-    1 => 'aux'
+    0 => 'aux'
+    1 => 'main'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:277
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:415

Details

SubjectRepoBranchLines +/-
Ignore order of slot roles in test assertionsmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jun 14 2018, 9:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2018, 9:19 PM
Krinkle added a project: MediaWiki-Core-Tests.Jun 14 2018, 9:19 PM
Krinkle edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1).
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Krinkle added projects: PHP 7.1 support, MW-1.32-release.
Krinkle removed a subscriber: MediaWiki-Core-Tests.
Krinkle edited projects, added MW-1.33-release; removed MW-1.32-release.Jun 14 2018, 9:21 PM
Krinkle updated the task description. (Show Details)
Krinkle edited projects, added MW-1.32-release; removed MW-1.33-release.
Reedy renamed this task from [Regresion] PHPUnit fails on PHP 7.1 and HHVM 3.18 (1 failure: McrRevisionStoreDbTest) to PHPUnit fails on PHP 7.1 and HHVM 3.18 (1 failure: McrRevisionStoreDbTest).Jun 14 2018, 11:47 PM
Reedy added a project: Regression.
Legoktm subscribed.Jun 14 2018, 11:50 PM

Noooooooooooooooooooooooo :'(

Krinkle edited projects, added Wikimedia-production-error (ARCHIVED -- Shared Build Failure); removed Regression.Jun 14 2018, 11:56 PM
gerritbot subscribed.Jun 15 2018, 9:57 AM

Change 440513 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Ignore order of lot roles in test assertions

https://gerrit.wikimedia.org/r/440513

gerritbot added a project: Patch-For-Review.Jun 15 2018, 9:57 AM
gerritbot added a comment.Jun 15 2018, 10:47 AM

Change 440513 merged by jenkins-bot:
[mediawiki/core@master] Ignore order of slot roles in test assertions

https://gerrit.wikimedia.org/r/440513

daniel added a comment.Jun 15 2018, 10:56 AM

Should be fixed now, please confirm.

Krinkle closed this task as Resolved.Jun 15 2018, 12:20 PM
Krinkle assigned this task to daniel.
Krinkle moved this task from Untriaged to Resolved on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.

Confirmed. Thanks :)

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 12:00 PM
• Vvjjkkii renamed this task from PHPUnit fails on PHP 7.1 and HHVM 3.18 (1 failure: McrRevisionStoreDbTest) to kzaaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed daniel as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Krinkle renamed this task from kzaaaaaaaa to PHPUnit fails on PHP 7.1 and HHVM 3.18 (1 failure: McrRevisionStoreDbTest).Jul 1 2018, 11:58 PM
Krinkle closed this task as Resolved.
Krinkle claimed this task.
Krinkle removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser, Patch-For-Review.
Krinkle updated the task description. (Show Details)
Krinkle added a subscriber: Aklapper.
CommunityTechBot reassigned this task from Krinkle to daniel.Jul 5 2018, 7:02 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
CCicalese_WMF moved this task from Inbox to Done on the Multi-Content-Revisions board.Jul 13 2018, 3:23 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL