Page MenuHomePhabricator

Syntax highlighting interacts badly with magnify on Android
Closed, InvalidPublic

Description

Nexus 7 Build/MOB30X
Android 6.0.1
Chrome 67.0.3396.87

Screenshot_chrome.png (1×1 px, 62 KB)

There's a feature on Android Chrome that pops up a zoomed-in (magnified) area of the screen if the exact location of a tap isn't clear. That seems to be an important part of reproducing this. I'm not able to reproduce this 100% of the time, but pretty close to it.

Steps to reproduce:

  • Edit a page containing a wikilink.
  • Tap just before the first opening bracket of the link.
  • Wait for the magnify box to come up
    Screenshot_magnify.png (1×1 px, 161 KB)
  • Again, tap just before the opening bracket.

At this point, I observe that the magnify box goes away, I can see the insertion cursor appear between the space and the open bracket, and then after about 1/4 second, the insertion point jumps to another location, somewhat to the left of the original location.

Screenshot_cursor.png (1×1 px, 170 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@RoySmith It seems to me that Android is having trouble with syntax highlighting in wikitext. Do you have the same problem when you edit the code in the editor in this example on Android?

No, it does not happen in demo you linked to.

Niharika triaged this task as Medium priority.Jun 18 2018, 10:38 PM
Niharika removed a project: Community-Tech.

Thanks for testing!

BTW, I can reproduce this with both wikilinks (double brackets) and external links (single brackets).

@RoySmith To clarify, does magnify always appear with highlighting or it only appears when it's not clear on the click point?

I'm not sure I'm parsing your question right, but there are certainly instances where I tap on a piece of text and the insertion point appears there without the magnify box ever appearing. And, in those cases, I never see the insertion point jump to a new location.

And, the presence of wikitext does not seem to affect whether or not magnify appears.

I'll try to rig up a camera and take a video of my sceen while I do that. It might make more sense then.

@RoySmith I got it. I was asking if the presence of highlighting causes magnify to appear more frequently than normal. You answered it. Thanks.

Vvjjkkii renamed this task from Syntax highlighting interacts badly with magnify on Android to 3raaaaaaaa.Jul 1 2018, 1:03 AM
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 3raaaaaaaa to Syntax highlighting interacts badly with magnify on Android.Jul 2 2018, 5:11 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.
MusikAnimal subscribed.

I can't repro in CodeMirror 6 on Android 14 and Chrome 133. I'm guessing this bug is unique to CM5.

CodeMirror 5 has officially been retired, thus closing as invalid. Please re-open or file a new bug should the issue persist with the new version.