Page MenuHomePhabricator
Create Task
Maniphest T197541

Delete actions do not appear on watchlist (Hungarian Wikipedia issue)
Closed, ResolvedPublic
Actions

Description

On the Hungarian Wikipedia the delete actions do not appear on user's watchlist, however other actions (such as move, suppress, undelete) do. It is a known problem and was fixed at least once (maybe around 2014?) during my career but it returned again. The interesting thing is that the mobile-side is not affected. It should be fixed.

Example:

My watchlist on desktop:

1.PNG (1,366×510 px, 78 KB)

My watchlist on mobile:
2.png (1,080×1,920 px, 132 KB)

How to reproduce:

  • Go to Kategória:Azonnali törlésre váró lapok (Category:Candidates for speedy deletion in Hungarian)
  • Watchlist a random page (if you cannot find any candidates, try it later)
  • Check your watchlist after few hours

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Remove impossible query condition"mediawiki/extensions/LiquidThreadsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Bencemac created this task.Jun 17 2018, 2:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2018, 2:15 PM
matej_suchanek removed a project: Wikimedia-Site-requests.Jun 17 2018, 4:33 PM
Urbanecm subscribed.Jun 17 2018, 4:51 PM
Urbanecm added a comment.Jun 17 2018, 4:55 PM

What cames to my mind: Try to disable "new filters for edit review" in Beta preferences, if it will change anything.

Bencemac added a comment.Jun 17 2018, 5:07 PM

@Urbanecm It doesn't help. It affects every editor, no matter they are using the old or the new watchlist.

• Vvjjkkii renamed this task from Delete actions do dot appear on watchlist (Hungarian Wikipedia issue) to 2raaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 2raaaaaaaa to Delete actions do dot appear on watchlist (Hungarian Wikipedia issue).Jul 2 2018, 4:43 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Bencemac renamed this task from Delete actions do dot appear on watchlist (Hungarian Wikipedia issue) to Delete actions do not appear on watchlist (Hungarian Wikipedia issue).Jul 21 2018, 1:18 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 21 2018, 1:18 PM
Catrope moved this task from Inbox to Needs Discussion on the Growth-Team board.Aug 20 2018, 11:24 PM
Catrope subscribed.Aug 21 2018, 5:38 PM

I can reproduce this, and I can confirm that it happens on huwiki but doesn't happen on testwiki or on enwiki. Very strange.

JTannerWMF moved this task from Needs Discussion to Up next Sprint on the Growth-Team board.Aug 23 2018, 12:26 PM
MMiller_WMF subscribed.Aug 27 2018, 6:19 PM

We are considering this for Growth team maintenance work.

Bencemac updated the task description. (Show Details)Aug 28 2018, 6:47 PM
JTannerWMF edited projects, added: Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team.Aug 29 2018, 5:43 PM
JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 29 2018, 5:53 PM
Catrope added a comment.Sep 7 2018, 12:25 AM

Mystery solved: this is caused by MediaWiki-extensions-LiquidThreads adding page_namespace != 90 (90 is the Thread namespace) to the WHERE clause, which then causes all rows that don't have a corresponding row in the page table (meaning, deleted pages) to be dropped, because NULL != 90 is false (that sounds strange, but any comparison involving null is false).

Catrope added a comment.Sep 7 2018, 12:44 AM

This was caused by rELQT5c867745a737: Remove impossible query condition, which we should just revert.

gerritbot subscribed.Sep 7 2018, 12:51 AM

Change 458621 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/LiquidThreads@master] Revert "Remove impossible query condition"

https://gerrit.wikimedia.org/r/458621

gerritbot added a project: Patch-For-Review.Sep 7 2018, 12:51 AM
Catrope claimed this task.Sep 7 2018, 12:51 AM
Catrope moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Sep 7 2018, 4:36 AM

Change 458621 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Revert "Remove impossible query condition"

https://gerrit.wikimedia.org/r/458621

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 7 2018, 5:00 AM
Bencemac added a comment.Sep 7 2018, 6:05 AM
In T197541#4564828, @Catrope wrote:

because NULL != 90 is false (that sounds strange, but any comparison involving null is false).

Hmm, is this MediaWiki specific?

Catrope added a comment.Sep 7 2018, 5:22 PM
In T197541#4565088, @Bencemac wrote:
In T197541#4564828, @Catrope wrote:

because NULL != 90 is false (that sounds strange, but any comparison involving null is false).

Hmm, is this MediaWiki specific?

No, see the MySQL documentation: https://dev.mysql.com/doc/refman/8.0/en/working-with-null.html

Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 7 2018, 5:24 PM
Etonkovidova closed this task as Resolved.EditedSep 17 2018, 8:51 PM
Etonkovidova subscribed.

The fix works in betalabs and in testwiki (wmf.22):

Screen Shot 2018-09-18 at 3.48.00 PM.png (785×459 px, 70 KB)

Urbanecm edited subscribers, added: Urbanecm_WMF; removed: Urbanecm.Aug 26 2020, 2:10 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 26 2020, 2:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits