Page MenuHomePhabricator

Prevent impression counting until banner is displayed
Closed, DuplicatePublic

Description

In most cases, banner display is delayed by 7.5 seconds.

Acceptance criteria:

  • Banner impressions are only counted, after the display animation ends.
  • Impressions of banners that are (partly) displayed immediately (e. g. the mobile mini banner) are still counted immediately.

Background:
A comment in T176334 hints on how to properly prevent impression recording.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Vvjjkkii renamed this task from Prevent impression counting until banner is displayed to braaaaaaaa.Jul 1 2018, 1:03 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from braaaaaaaa to Prevent impression counting until banner is displayed.Jul 2 2018, 4:42 AM
CommunityTechBot closed this task as a duplicate.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.