Page MenuHomePhabricator

Login information doesn't get deleted when users delete the app, since they are stored by the OS
Closed, DeclinedPublic

Description

Steps to reproduce

1, Clean install 5.8.1.1403
2, Log in in the app
3, Delete the app
4, Install 5.8.2.1421

Expected result

User is logged out

Actual result

User is still logged in

Event Timeline

JMinor triaged this task as Medium priority.Jun 25 2018, 6:23 PM
JMinor subscribed.

We keep having problems really "cleaning out" after uninstall...

Did a bit of investigating. This is acutally sort-of intentional. Basically we are storing your credentials in the hardware encrypted OS keychain. This means when the app is reinstalled the OS finds these stored credentials and uses them to log you back in.

This is similar to how Google and other platforms work on iOS/Safari. And storing credentials in the keychain provides a level of protection we want our users to have (for example, fingerprint access requirement and potetnially sharing across Safari/iOS).

I think the issue here is that this happens silently and "just works" when the app is reinstalled. Rather than remove this functionality (and lose the advantages of Keychain storage), we should consider popping up an opt-in message "Wikipedia login information found in your keychain. Log in with stored username and password?" with options to login, ignore or delete the keychain entry.

Taking out of scope of 6.0 as there is a bit of complexity to any solution and scope on 6.0 is pretty full.

JMinor renamed this task from [Bug] Login information doesn't get deleted when users delete the app to Login information doesn't get deleted when users delete the app, since they are stored by the OS.Jun 25 2018, 7:47 PM
Vvjjkkii renamed this task from Login information doesn't get deleted when users delete the app, since they are stored by the OS to apaaaaaaaa.Jul 1 2018, 1:03 AM
Vvjjkkii removed JMinor as the assignee of this task.
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from apaaaaaaaa to Login information doesn't get deleted when users delete the app, since they are stored by the OS.Jul 2 2018, 1:40 PM
CommunityTechBot assigned this task to JMinor.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.

@JMinor Thanks for the investigation and explanation!