Page MenuHomePhabricator
Create Task
Maniphest T197681

Add integration test covering import functionality in core
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Minimal test case should be a file with 2 file revisions and 2 text revisions that go through the import process.
Assertions must check both, the old revisions and the current one.

Details

SubjectRepoBranchLines +/-
Extend Importer integration test using multiple revisionsmediawiki/extensions/FileImportermaster+72 -14
Add integration test for FileRevisionFromRemoteUrlmediawiki/extensions/FileImportermaster+168 -33
Add integration test for TextRevisionFromTextRevisionmediawiki/extensions/FileImportermaster+133 -0
Customize query in gerrit

Related Objects

Mentioned In
rEFLIcf0c33f89e8c: Extend Importer integration test using multiple revisions
rEFLI1276cdaeab92: Extend Importer integration test using multiple revisions
rEFLIa02cee97a4ea: Extend Importer integration test using multiple revisions
rEFLI9483b7227b3a: Extend Importer integration test using multiple revisions
rEFLIf16f10ef1d61: Extend Importer integration test using multiple revisions
rEFLI46dca71c7ee5: Extend Importer integration test using multiple revisions
rEFLIc11f15d4b82a: Extend Importer integration test using multiple revisions
rEFLIdf7616638d76: Extend Importer integration test using multiple revisions
rEFLI3c029ca5d9e1: Extend Importer integration test using multiple revisions
rEFLI7579034b5acc: Extend Importer integration test using multiple revisions
rEFLI5cf70eb6e8bd: Extend Importer integration test using multiple revisions
rEFLIaa54178c6c6a: [WIP] Extend Importer integration test using multiple revisions
rEFLI33ef14c3322a: [WIP] Extend Importer integration test using multiple revisions
rEFLI7c578c2187a6: Extend Importer integration test using multiple revisions
rEFLI70409d62edc4: [WIP] Extend Importer integration test using multiple revisions
rEFLI0bc487e514ac: Add integration test for FileRevisionFromRemoteUrl
rEFLI51a51333f7cb: Add ImporterComponentTest
rEFLI93141d052e86: Add ImporterComponentTest
rEFLI94209ab3b0ed: Add ImporterComponentTest
rEFLIf6a9bc459171: Add ImporterComponentTest
rEFLId8b118ae358c: Add integration test for TextRevisionFromTextRevision
rEFLI0bfa82e2a4c6: Add ImporterComponentTest
rEFLI00e83741ba4c: Add integration test for TextRevisionFromTextRevision
rEFLI95652c3116ef: Add ImporterComponentTest
rEFLIf47ae5614e8b: Add integration test for TextRevisionFromTextRevision
Mentioned Here
T200001: Quickly importing two versions of a file leads to timing issues in LocalFile.php

Event Timeline

Tobi_WMDE_SW created this task.Jun 19 2018, 12:58 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJun 19 2018, 12:58 PM
Tobi_WMDE_SW moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.Jun 19 2018, 12:58 PM
WMDE-Fisch claimed this task.Jun 28 2018, 11:50 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-06-19 board.
• Vvjjkkii renamed this task from Add integration test covering import functionality in core to 6naaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii removed WMDE-Fisch as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii removed the point value for this task.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail.
• Vvjjkkii added a subscriber: WMDE-Fisch.
CommunityTechBot renamed this task from 6naaaaaaaa to Add integration test covering import functionality in core.Jul 2 2018, 11:47 AM
CommunityTechBot assigned this task to WMDE-Fisch.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot removed projects: Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot set the point value for this task to 8.
CommunityTechBot removed a subscriber: WMDE-Fisch.
Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-07-03.Jul 3 2018, 1:06 PM
Lea_WMDE changed the point value for this task from 8 to 5.
Lea_WMDE subscribed.

open TODOS:

  • make the two tests work together
  • use two files and two revisions
Lea_WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-07-03 board.Jul 3 2018, 1:06 PM
Lea_WMDE merged a task: T190826: Improve code coverage of Importer.Jul 3 2018, 1:10 PM
Lea_WMDE added a subscriber: Aklapper.
gerritbot subscribed.Jul 5 2018, 3:57 PM

Change 444010 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Add integration test for TextRevisionFromTextRevision

https://gerrit.wikimedia.org/r/444010

gerritbot added a project: Patch-For-Review.Jul 5 2018, 3:57 PM
WMDE-Fisch mentioned this in rEFLIf47ae5614e8b: Add integration test for TextRevisionFromTextRevision.Jul 5 2018, 4:00 PM
thiemowmde mentioned this in rEFLI95652c3116ef: Add ImporterComponentTest.Jul 5 2018, 4:59 PM
thiemowmde mentioned this in rEFLI00e83741ba4c: Add integration test for TextRevisionFromTextRevision.Jul 6 2018, 6:10 AM
thiemowmde mentioned this in rEFLI0bfa82e2a4c6: Add ImporterComponentTest.Jul 6 2018, 8:41 AM
WMDE-Fisch mentioned this in rEFLId8b118ae358c: Add integration test for TextRevisionFromTextRevision.Jul 10 2018, 8:50 AM
gerritbot added a comment.Jul 10 2018, 8:58 AM

Change 444010 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add integration test for TextRevisionFromTextRevision

https://gerrit.wikimedia.org/r/444010

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 10 2018, 9:00 AM
WMDE-Fisch moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.Jul 11 2018, 7:57 AM
Andrew-WMDE mentioned this in rEFLIf6a9bc459171: Add ImporterComponentTest.Jul 11 2018, 1:23 PM
Andrew-WMDE mentioned this in rEFLI94209ab3b0ed: Add ImporterComponentTest.Jul 11 2018, 2:01 PM
Andrew-WMDE mentioned this in rEFLI93141d052e86: Add ImporterComponentTest.Jul 11 2018, 2:04 PM
Andrew-WMDE mentioned this in rEFLI51a51333f7cb: Add ImporterComponentTest.Jul 11 2018, 2:11 PM
gerritbot added a comment.Jul 11 2018, 4:23 PM

Change 445201 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Add integration test for FileRevisionFromRemoteUrl

https://gerrit.wikimedia.org/r/445201

WMDE-Fisch mentioned this in rEFLI0bc487e514ac: Add integration test for FileRevisionFromRemoteUrl.Jul 11 2018, 4:25 PM
gerritbot added a comment.Jul 11 2018, 4:50 PM

Change 445201 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add integration test for FileRevisionFromRemoteUrl

https://gerrit.wikimedia.org/r/445201

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 11 2018, 5:00 PM
gerritbot added a comment.Jul 13 2018, 3:29 PM

Change 445632 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Extend Importer integration test using multiple revisions

https://gerrit.wikimedia.org/r/445632

WMDE-Fisch mentioned this in rEFLI70409d62edc4: [WIP] Extend Importer integration test using multiple revisions.Jul 13 2018, 3:31 PM
WMDE-Fisch mentioned this in rEFLI7c578c2187a6: Extend Importer integration test using multiple revisions.
WMDE-Fisch mentioned this in rEFLI33ef14c3322a: [WIP] Extend Importer integration test using multiple revisions.Jul 16 2018, 10:47 AM
WMDE-Fisch mentioned this in rEFLIaa54178c6c6a: [WIP] Extend Importer integration test using multiple revisions.Jul 16 2018, 12:15 PM
WMDE-Fisch mentioned this in rEFLI5cf70eb6e8bd: Extend Importer integration test using multiple revisions.Jul 16 2018, 4:25 PM
WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-07-03 board.Jul 17 2018, 8:29 AM
WMDE-Fisch mentioned this in rEFLI7579034b5acc: Extend Importer integration test using multiple revisions.Jul 17 2018, 10:46 AM
WMDE-Fisch changed the point value for this task from 5 to 1.Jul 17 2018, 12:06 PM
WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2018-07-17.
WMDE-Fisch moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-07-17 board.
WMDE-Fisch changed the point value for this task from 1 to 2.
Tobi_WMDE_SW moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-07-17 board.Jul 18 2018, 12:36 PM
Lea_WMDE added a comment.Jul 18 2018, 4:04 PM

Should I do anything here? If not, we could move it to done I guess :)

WMDE-Fisch added a comment.Jul 19 2018, 12:43 PM

@Lea_WMDE yepp you're right, lets move it to done.

One thing though. While doing this I ran into an issue in core that was revealed by the integration test covering two file revisions. There seems to be (another) timing issue with timestamp file names. I just created a ticket for that: T200001 (look at that number :-) ).

The test is fine on the CI and we already tested the import of files with many revisions several times now, so I am pretty sure it does not affect us very much in production. Still it's something that needs be solved. - But that's out of the scope of this ticket. So let's move it to done.

Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-07-17 board.Jul 20 2018, 12:06 PM
Lea_WMDE closed this task as Resolved.Aug 3 2018, 6:48 AM
WMDE-Fisch mentioned this in rEFLI3c029ca5d9e1: Extend Importer integration test using multiple revisions.Nov 21 2018, 1:34 PM
WMDE-Fisch mentioned this in rEFLIdf7616638d76: Extend Importer integration test using multiple revisions.Dec 21 2018, 12:17 PM
WMDE-Fisch mentioned this in rEFLIc11f15d4b82a: Extend Importer integration test using multiple revisions.Dec 21 2018, 12:53 PM
WMDE-Fisch mentioned this in rEFLI46dca71c7ee5: Extend Importer integration test using multiple revisions.Dec 29 2018, 12:58 PM
WMDE-Fisch mentioned this in rEFLIf16f10ef1d61: Extend Importer integration test using multiple revisions.Jan 2 2019, 1:02 PM
WMDE-Fisch mentioned this in rEFLI9483b7227b3a: Extend Importer integration test using multiple revisions.Jan 4 2019, 4:12 PM
WMDE-Fisch mentioned this in rEFLIa02cee97a4ea: Extend Importer integration test using multiple revisions.Jan 8 2019, 10:37 AM
WMDE-Fisch mentioned this in rEFLI1276cdaeab92: Extend Importer integration test using multiple revisions.Jan 8 2019, 10:47 AM
WMDE-Fisch mentioned this in rEFLIcf0c33f89e8c: Extend Importer integration test using multiple revisions.Jan 8 2019, 11:57 AM
gerritbot added a comment.Jan 8 2019, 12:01 PM

Change 445632 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Extend Importer integration test using multiple revisions

https://gerrit.wikimedia.org/r/445632

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptJan 8 2019, 12:01 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:58 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 3:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL