Page MenuHomePhabricator

OutputPage::parseInline seems broken as <div class="mw-parser-output"> is wrapped around the result
Open, MediumPublic

Description

This is about the function documented here: https://doc.wikimedia.org/mediawiki-core/master/php/classOutputPage.html#aaa1c0ae62fd0a36703d1736b7ecc8c7c In old MediaWiki versions this would send wikitext through the parser, strip the paragraph tags and return the result. Since MediaWiki 1.30 there is an additional wrapping div like <div class="mw-parser-output"></div> that is wrapped around the result, which considering it is a block level element seems counter-intuitive for a function called parseInline. My question now is if this function should strip that div as well? This could either be part of Parser::stripOuterParagraph or be part of a similar function to that.

Event Timeline

Aklapper renamed this task from OutputPage::parseInline seems broken to OutputPage::parseInline seems broken as <div class="mw-parser-output"> is wrapped around the result.Jun 19 2018, 7:26 PM
Vvjjkkii renamed this task from OutputPage::parseInline seems broken as <div class="mw-parser-output"> is wrapped around the result to tnaaaaaaaa.Jul 1 2018, 1:02 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
FO-nTTaX renamed this task from tnaaaaaaaa to OutputPage::parseInline seems broken as <div class="mw-parser-output"> is wrapped around the result.Jul 1 2018, 2:24 PM
FO-nTTaX lowered the priority of this task from High to Medium.
FO-nTTaX updated the task description. (Show Details)
FO-nTTaX added a subscriber: Aklapper.