Page MenuHomePhabricator

Update the toolbar icons and overflow options in the "exploded tabs" view in the "Explicit reading mode" app and article navigation concept
Closed, InvalidPublic

Description

NOTE: See Zeplin project for redlined mocks, tagged with Explicit reading mode
ER 07 - exploded view 2 tabs open.png (1×720 px, 240 KB)
With overflow
ER 07ii - exploded view with overflow.png (1×720 px, 250 KB)

Event Timeline

Vvjjkkii renamed this task from Update the toolbar icons and overflow options in the "exploded tabs" view in the "Explicit reading mode" app and article navigation concept to fnaaaaaaaa.Jul 1 2018, 1:02 AM
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from fnaaaaaaaa to Update the toolbar icons and overflow options in the "exploded tabs" view in the "Explicit reading mode" app and article navigation concept.Jul 2 2018, 11:44 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.

Change 451802 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@unified_activity] [WIP] Update the 'exploded tabs' toolbar icons and overflow options - Explicit reading mode

https://gerrit.wikimedia.org/r/451802

@RHo couple questions:

-There is now no option to close all tabs at once
-What options should the overflow icon contain?
-Could you please provide one image each for light,dark and black modes?

Hi @Sharvaniharan - please see responses inline below:

@RHo couple questions:
-There is now no option to close all tabs at once

– it's one of the options in the overflow

-What options should the overflow icon contain?

– see mock - options are to Open a new tab, Close all tabs, Go to Recently read (previously called History)

-Could you please provide one image each for light,dark and black modes?

  • It uses the existing color scheme as defined by the Android color themes - specifically Base for the background color, and the other elements use same colors as the article view

hi @Sharvaniharan – please also confirm that the changes you've made on this ticket are merged into the prototype for testing at http://releases.wikimedia.org/mobile/android/wikipedia/scratch/app-alpha-prototype_2.apk

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 22 2018, 9:16 PM

@RHo All changes are made... but i guess i dont have the right permissions to copy the apk there...apk is ready.. i will troubleshoot permissions with Dmitry tomorrow and upload..

hi @Sharvaniharan - would be great if you can send me the most up-to-date APK in the meantime whilst posting to the releases page is worked out. thanks!

Dbrant subscribed.

superseded by current design