Maniphest T197797

PHP parameter and variable warnings in wfAjaxCollectionSuggestUndoArticle
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	• Niedzielski
	Jun 20 2018, 1:58 PM

Description

Logstash is reporting a warning and notice for the Collection extension:

Warning: wfAjaxCollectionSuggestUndoArticle() expects exactly 2 parameters, 1 given in /srv/mediawiki/php-1.32.0-wmf.8/extensions/Collection/Collection.php on line 562
Notice: Undefined variable: article in /srv/mediawiki/php-1.32.0-wmf.8/extensions/Collection/Collection.php on line 562

Note: there's no extension.json in this project and $wgAjaxExportList is deprecated.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Set defaults on arguments of CollectionAjaxFunctions class	mediawiki/extensions/Collection	master	+11 -11

Customize query in gerrit

Related Objects

Mentioned In: T224922: Code Stewardship Review: Collection Extension

Event Timeline

• Niedzielski created this task.Jun 20 2018, 1:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2018, 1:58 PM

• Niedzielski added a project: Technical-Debt.Jun 20 2018, 1:59 PM

Jdlrobson edited projects, added Web-Team-Backlog-Archived (Tracking); removed Web-Team-Backlog-Archived.Jun 20 2018, 2:27 PM

• Vvjjkkii renamed this task from PHP parameter and variable warnings in wfAjaxCollectionSuggestUndoArticle to ykaaaaaaaa.Jul 1 2018, 1:02 AM

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from ykaaaaaaaa to PHP parameter and variable warnings in wfAjaxCollectionSuggestUndoArticle.Jul 2 2018, 11:31 AM

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot added a subscriber: Aklapper.

Change 513741 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Collection@master] Set defaults on arguments of CollectionAjaxFunctions class

https://gerrit.wikimedia.org/r/513741

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptJun 1 2019, 8:52 PM

gerritbot added a project: Patch-For-Review.Jun 1 2019, 8:52 PM

Krinkle edited projects, added Wikimedia-production-error; removed Technical-Debt.Jun 10 2019, 8:17 PM

Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.

Change 513741 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Set defaults on arguments of CollectionAjaxFunctions class

https://gerrit.wikimedia.org/r/513741

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 10 2019, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2019, 9:10 PM

Umherirrender closed this task as Resolved.Jun 11 2019, 6:59 PM

Umherirrender claimed this task.

Krinkle mentioned this in T224922: Code Stewardship Review: Collection Extension.Jun 18 2019, 11:15 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM

PHP parameter and variable warnings in wfAjaxCollectionSuggestUndoArticleClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

PHP parameter and variable warnings in wfAjaxCollectionSuggestUndoArticle
Closed, ResolvedPublicPRODUCTION ERROR
Actions