Page MenuHomePhabricator
Create Task
Maniphest T197806

jsduck not found
Closed, ResolvedPublic
Actions

Description

Previously jsduck was installed globally on CI. Something seems to have broken this
Seen on:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/441172/
Blocking merges.

Issue in the mwext-jsduck-publish job?

Details

ProjectBranchLines +/-Subject
integration/configmaster+3 -3Bump Quibble jobs to 0.0.18-2 for JSDuck
integration/configmaster+43 -0docker: add JSDuck to Quibble images
Customize query in gerrit

Related Objects

Event Timeline

• Jdlrobson created this task.Jun 20 2018, 3:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2018, 3:40 PM
• Jdlrobson triaged this task as High priority.Jun 20 2018, 3:40 PM
• Jdlrobson updated the task description. (Show Details)
• Jdlrobson added a project: Docker-Hub-MediaWiki.
• Jdlrobson updated the task description. (Show Details)
hashar added a comment.Jun 20 2018, 4:23 PM

That one is my fault, I thought jsduck has been phased out entirely from the master branches in favor of JSDoc T138401

I have to add it to the Quibble image :/

gerritbot added a subscriber: gerritbot.Jun 20 2018, 4:30 PM

Change 441230 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: add JSDuck to Quibble images

https://gerrit.wikimedia.org/r/441230

gerritbot added a project: Patch-For-Review.Jun 20 2018, 4:30 PM

Change 441231 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Bump Quibble jobs to 0.0.18-2 for JSDuck

https://gerrit.wikimedia.org/r/441231

Stashbot added a subscriber: Stashbot.Jun 20 2018, 4:32 PM

Mentioned in SAL (#wikimedia-releng) [2018-06-20T16:32:28Z] <hashar> Rebuilding Quibble images to get jsduck included in the image | T197806

gerritbot added a comment.Jun 20 2018, 4:33 PM

Change 441230 merged by jenkins-bot:
[integration/config@master] docker: add JSDuck to Quibble images

https://gerrit.wikimedia.org/r/441230

hashar added a comment.Jun 20 2018, 4:35 PM

The Docker containers are being rebuild which takes roughly half an hour. Once completed, we would "just" need to update the jenkins jobs with https://gerrit.wikimedia.org/r/441231

hashar claimed this task.Jun 20 2018, 4:35 PM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 20 2018, 4:35 PM
Stashbot added a comment.Jun 20 2018, 5:33 PM

Mentioned in SAL (#wikimedia-releng) [2018-06-20T17:33:29Z] <hashar> Refreshing Quibble Jenkins jobs to use 0.0.18-2 docker image. That adds JSDuck | T197806

gerritbot added a comment.Jun 20 2018, 5:36 PM

Change 441231 merged by jenkins-bot:
[integration/config@master] Bump Quibble jobs to 0.0.18-2 for JSDuck

https://gerrit.wikimedia.org/r/441231

hashar closed this task as Resolved.Jun 20 2018, 5:50 PM

Seems to be working now:

00:02:54.546 INFO:test.run_extskin:Running "npm test" for MobileFrontend
....
00:04:14.714 > @ doc /workspace/src/extensions/MobileFrontend
00:04:14.714 > jsduck
00:04:14.714 
00:04:43.601 INFO:test.run_extskin:MobileFrontend: git clean -xqdf

Sorry for the mess up

• Vvjjkkii renamed this task from jsduck not found to pkaaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed hashar as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from pkaaaaaaaa to jsduck not found.Jul 2 2018, 11:31 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to hashar.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL