Page MenuHomePhabricator
Create Task
Maniphest T197883

Popups: Update babel-preset-env and friends
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Keeping up to date with external software dependencies is important to keep code healthy.

babel-present-env has been archived and moved into babel core. Update it and related dependencies to the latest with best practices in MediaWiki's Page-Previews extension.

$:user\> grep -r "babel-preset-env" .
./package.json:    "babel-preset-env": "1.6.0",
./package-lock.json:    "babel-preset-env": {
./package-lock.json:      "resolved": "https://registry.npmjs.org/babel-preset-env/-/babel-preset-env-1.6.0.tgz",

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Switch from babel-preset-env to @babel/preset-envmediawiki/extensions/Popupsmaster+13 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Niedzielski created this task.Jun 21 2018, 3:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2018, 3:59 PM
• Niedzielski moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog-Archived board.Jun 21 2018, 4:03 PM
Jdlrobson updated the task description. (Show Details)Jun 21 2018, 5:22 PM
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog-Archived board.
Jdlrobson set the point value for this task to 2.Jun 26 2018, 4:45 PM
Jdlrobson subscribed.

This requires removing packages as well as updating.

• Vvjjkkii renamed this task from Update babel-preset-env and friends to kiaaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii removed the point value 2 for this task.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from kiaaaaaaaa to Update babel-preset-env and friends.Jul 2 2018, 11:21 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot set the point value for this task to 2.
CommunityTechBot added a subscriber: Aklapper.
ovasileva moved this task from Backlog to Next Up on the Page-Previews board.Jul 25 2018, 8:22 AM
Jdlrobson added a project: Google-Code-in-2018.Sep 19 2018, 11:51 PM
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptSep 19 2018, 11:51 PM
Aklapper updated the task description. (Show Details)Oct 7 2018, 2:38 AM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.

https://codein.withgoogle.com/tasks/6626352292691968/

• Niedzielski renamed this task from Update babel-preset-env and friends to Upgrade Popups dependencies.Nov 12 2018, 9:10 PM
• Niedzielski updated the task description. (Show Details)
Jdlrobson renamed this task from Upgrade Popups dependencies to Update babel-preset-env and friends.Nov 12 2018, 9:12 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a parent task: T209314: Popups: Upgrade Popups dependencies .

@Niedzielski this is currently an active google code in task so I've reverted back to old title/description to avoid confusion there.
I've created T209314 to capture the new concerns and made this a subtask. Trust that's okay with you.

• Niedzielski added a comment.Nov 12 2018, 9:25 PM

Jdlrobson renamed this task from Update babel-preset-env and friends to Popups: Update babel-preset-env and friends.Nov 15 2018, 6:44 PM
Jdlrobson raised the priority of this task from Medium to High.
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog-Archived board.
ovasileva edited projects, added Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog-Archived.Nov 27 2018, 5:05 PM
Shreyasminocha claimed this task.Dec 3 2018, 9:03 AM
Shreyasminocha removed Shreyasminocha as the assignee of this task.Dec 4 2018, 9:27 AM
Shreyasminocha subscribed.

Will re-claim once I complete my current GCI task (unless someone beats me to it of course).

Shreyasminocha claimed this task.Dec 7 2018, 4:27 AM
gerritbot subscribed.Dec 8 2018, 5:49 AM

Change 478392 had a related patch set uploaded (by Shreyasminocha; owner: Shreyasminocha):
[mediawiki/extensions/Popups@master] Switch from babel-preset-env to @babel/preset-env

https://gerrit.wikimedia.org/r/478392

gerritbot added a project: Patch-For-Review.Dec 8 2018, 5:49 AM
Jdlrobson moved this task from To Do to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 11 2018, 3:11 PM
gerritbot added a comment.Dec 11 2018, 4:17 PM

Change 478392 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Switch from babel-preset-env to @babel/preset-env

https://gerrit.wikimedia.org/r/478392

• Niedzielski removed Shreyasminocha as the assignee of this task.Dec 11 2018, 4:21 PM
• Niedzielski moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Thank you for your work, @Shreyasminocha! Your patches have been merged \o/

I've unassigned this task so that it can go through standard QA process.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 11 2018, 5:00 PM
• nray claimed this task.Dec 11 2018, 6:27 PM
phuedx subscribed.Dec 12 2018, 6:41 PM

@nray: As discussed, here's the list of all Page Previews test cases that @ovasileva and @ABorbaWMF created. As you can see, it's long. I would suggest that you use your discretion about how many cases you run through (e.g. we have browser tests covering previews appearing/disappearing when you interact with a link).

Unfortunately, both the staging server and the Beta Cluster no longer have the Page Previews testing pages present. I'll try and dig out the corpus and re-import it to both of those servers.

phuedx added a comment.Dec 12 2018, 6:45 PM
In T197883#4818045, @phuedx wrote:

Unfortunately, both the staging server and the Beta Cluster no longer have the Page Previews testing pages present. I'll try and dig out the corpus and re-import it to both of those servers.

The corpus I created is here (tests/manual/corpus.xml): https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/315061/

• nray edited projects, added Web-Team-Backlog-Archived; removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2), Google-Code-in-2018.Dec 12 2018, 9:53 PM

Tested anon / logged in users, previews with images / no images using https://en.wikipedia.beta.wmflabs.org/wiki/VisualEditor. All appears to be working as intended.

• nray removed • nray as the assignee of this task.Dec 12 2018, 10:01 PM
• nray edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2), Google-Code-in-2018; removed Web-Team-Backlog-Archived.
• nray moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
• nray subscribed.
Jdlrobson closed this task as Resolved.Dec 12 2018, 10:34 PM
Jdlrobson claimed this task.

Good work all!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits