Review code for fetching Google Search Console data
Closed, ResolvedPublic

Description

Before we can use gsc-utils in production on stat1005 to collect and store Google Search Console stats for our sites, it needs to be reviewed and approved. There's not a whole lot going on in the two scripts (one for fetching list of sites, one for fetching stats for a site) so the CR should theoretically be a breeze :)

Thank you!

mpopov created this task.Thu, Jun 21, 7:53 PM
mpopov triaged this task as Normal priority.
mpopov moved this task from Triage to Tracking on the Product-Analytics board.

Hi @mpopov :]
Did you mean to tag this task with Product-Analytics or with Analytics?
Thanks!

Did you mean to tag this task with Product-Analytics or with Analytics?

Nope! The tag is for my team to track this ticket, but thanks for asking for clarification! I did intend to ping you about this is actually an excellent reminder to do that :)

Currently Adam is signed up to review the code (based on my past conversations with him around the GSC project) but it sounds like he's got a lot on his plate right now and might not be able to do this, so I was wondering if you would be able to do the CR? (And feel free to add whatever tags you think are necessary.)

Hey @mpopov, sure I can try.

I don't know the details of the data, but both scripts look good to me!

I think both scripts have this import from apiclient import errors that is not being used. But I might be wrong.

And the only detail that I think should be changed is the argparse description of the shorter script, which seems to be a duplicate from the longer one.

On the data privacy side, it seems the generated data sets have a couple potentially-identifying fields: country and device. But as far as I can see, there are no behavior/activity fields like URLs or page titles. So, I'd say that the generated data doesn't present a privacy threat. Unless device field detail is similar to that of a userAgent?

Hey @mpopov, sure I can try.

I don't know the details of the data, but both scripts look good to me!

Thank you, @mforns! I appreciate you taking the time for this.

I think both scripts have this import from apiclient import errors that is not being used. But I might be wrong.

I've been thinking about that one too. I'm nervous about removing it since Google's API docs included that line in the examples, but since you've also pointed it out I might see if it's safe to remove.

And the only detail that I think should be changed is the argparse description of the shorter script, which seems to be a duplicate from the longer one.

D'oh! Thanks, that's a good catch.

On the data privacy side, it seems the generated data sets have a couple potentially-identifying fields: country and device. But as far as I can see, there are no behavior/activity fields like URLs or page titles. So, I'd say that the generated data doesn't present a privacy threat. Unless device field detail is similar to that of a userAgent?

Quick background: the data is aggregates (# of impressions, # of clicks, and average position on the search results page), and device field is just desktop/mobile/tablet. Also the data for the time being will not be made publicly available and will only be accessible through Turnilo/Superset.

dr0ptp4kt closed this task as Resolved.Mon, Jun 25, 4:00 PM
dr0ptp4kt claimed this task.

Marking this as resolved. Thanks @mforns for the review.

Vvjjkkii renamed this task from Review code for fetching Google Search Console data to 6haaaaaaaa.Sun, Jul 1, 1:02 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii raised the priority of this task from Normal to High.
Vvjjkkii removed dr0ptp4kt as the assignee of this task.
Vvjjkkii updated the task description. (Show Details)
CommunityTechBot assigned this task to dr0ptp4kt.
CommunityTechBot lowered the priority of this task from High to Normal.
CommunityTechBot closed this task as Resolved.
CommunityTechBot renamed this task from 6haaaaaaaa to Review code for fetching Google Search Console data.
Deskana moved this task from Tag to Done on the SEO board.Fri, Jul 6, 10:28 AM