Page MenuHomePhabricator
Create Task
Maniphest T197910

OAuth approval dialog CSS and timeless do not play well together
Closed, ResolvedPublic
Actions

Description

I use Timeless as my primary skin with a browser width of 1024px (including window chrome). The centered dialog presented by Special:OAuth/authenticate in this skin and browser size is quite unattractive and a bit difficult to use if you are not used to the dialog.

Screen Shot 2018-06-21 at 15.30.03.png (876×1 px, 144 KB)
Screen Shot 2018-06-21 at 15.30.15.png (873×1 px, 139 KB)

Details

SubjectRepoBranchLines +/-
Make font smaller on OAuth approval dialogmediawiki/skins/Timelessmaster+6 -1
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Jun 21 2018, 10:20 PM
RileyBugz moved this task from Backlog to Compatibility on the Timeless board.Jun 23 2018, 4:19 PM
• Vvjjkkii renamed this task from OAuth approval dialog CSS and timeless do not play well together to thaaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
Izno renamed this task from thaaaaaaaa to OAuth approval dialog CSS and timeless do not play well together.Jul 1 2018, 2:47 PM
Izno raised the priority of this task from High to Needs Triage.
Izno removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Izno updated the task description. (Show Details)
Isarra subscribed.Aug 19 2019, 4:14 PM

...why the crap is the font-size 1.4em?! That's a bit much even on monobook.

Isarra added a comment.EditedAug 19 2019, 4:16 PM

I mean, mostly this seems to have been fixed already, but the size is still a bit much...

gerritbot added a comment.Aug 19 2019, 4:28 PM

Change 530890 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Make font smaller on OAuth approval dialog

https://gerrit.wikimedia.org/r/530890

gerritbot added a project: Patch-For-Review.Aug 19 2019, 4:28 PM
Isarra moved this task from Compatibility to In progress, or perhaps should be on the Timeless board.Aug 19 2019, 4:28 PM
gerritbot added a comment.Aug 19 2019, 9:30 PM

Change 530890 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Make font smaller on OAuth approval dialog

https://gerrit.wikimedia.org/r/530890

Restricted Repository Identity mentioned this in rSKIN0144948574aa: Update git submodules.Aug 19 2019, 9:31 PM
matmarex closed this task as Resolved.Aug 19 2019, 9:33 PM
matmarex assigned this task to Isarra.
Maintenance_bot removed a project: Patch-For-Review.Aug 19 2019, 10:10 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 11:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL