Page MenuHomePhabricator
Create Task
Maniphest T197918

Archive the MwEmbedSupport extension
Closed, ResolvedPublic
Actions

Description

Reason: Code moved into TimedMediaHandler in T164037: Move all the code out of MwEmbedSupport and into TimedMediaHandler, its only user.

Todo later (not doing this for now):

  • Empty repository and add an ARCHIVED file
  • Archive the extension's Diffusion repository
  • Mark the repository read-only in Gerrit
  • Delete the GitHub mirror
  • Archive Phabricator project MediaWiki-extensions-MwEmbedSupport for associated extension/skin and edit its description for associated extension/skin with a link to this ticket

Details

SubjectRepoBranchLines +/-
Archive the MwEmbedSupport extensionmediawiki/extensions/MwEmbedSupportmaster+0 -902
Remove MwEmbedSupportmediawiki/extensionsmaster+0 -5
[MwEmbedSupport] Archiveintegration/configmaster+1 -1
Stop branching the MwEmbedSupport extensionmediawiki/tools/releasemaster+0 -1
Note that the code of this extension was merged into TimedMediaHandlermediawiki/extensions/MwEmbedSupportmaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF triaged this task as Low priority.Jun 22 2018, 1:00 AM
Jdforrester-WMF created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2018, 1:00 AM
Jdforrester-WMF added a comment.Jun 22 2018, 1:00 AM

(Not quite yet, this code is still live in production until next week.)

MarcoAurelio changed the task status from Open to Stalled.Jun 22 2018, 7:08 AM
MarcoAurelio claimed this task.

To process next week onwards then.

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptJun 22 2018, 7:08 AM
MarcoAurelio moved this task from unsorted/backlog to later/stalled/blocked on the User-MarcoAurelio board.Jun 22 2018, 7:09 AM
MarcoAurelio moved this task from Backlog to Cleanup / Archival on the Diffusion-Repository-Administrators board.
MarcoAurelio moved this task from Backlog to delete on the Wikimedia-GitHub board.
MarcoAurelio moved this task from Untriaged to Archive extensions on the Projects-Cleanup board.
MarcoAurelio updated the task description. (Show Details)Jun 22 2018, 7:36 PM
gerritbot subscribed.Jun 23 2018, 7:45 AM

Change 441589 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/MwEmbedSupport@master] Note that the code of this extension was merged into TimedMediaHandler

https://gerrit.wikimedia.org/r/441589

gerritbot added a project: Patch-For-Review.Jun 23 2018, 7:45 AM
gerritbot added a comment.Jun 25 2018, 4:34 PM

Change 441589 merged by jenkins-bot:
[mediawiki/extensions/MwEmbedSupport@master] Note that the code of this extension was merged into TimedMediaHandler

https://gerrit.wikimedia.org/r/441589

Dinoguy1000 updated the task description. (Show Details)Jun 25 2018, 7:36 PM
gerritbot added a comment.Jun 25 2018, 7:40 PM

Change 441523 had a related patch set uploaded (by Greg Grossmeier; owner: Jforrester):
[mediawiki/tools/release@master] Stop branching the MwEmbedSupport extension

https://gerrit.wikimedia.org/r/441523

gerritbot added a comment.Jun 25 2018, 7:55 PM

Change 441523 merged by jenkins-bot:
[mediawiki/tools/release@master] Stop branching the MwEmbedSupport extension

https://gerrit.wikimedia.org/r/441523

Jdforrester-WMF updated the task description. (Show Details)Jun 25 2018, 8:01 PM
Stashbot subscribed.Jun 26 2018, 6:14 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-26T18:14:09Z] <marxarelli> scap sync for testwiki is currently failing on l10update due to MwEmbedSupport's deprecation but no change yet to mediawiki/extensions to remove the extension. blocking train on T197918

• dduvall added a parent task: T191056: 1.32.0-wmf.10 deployment blockers.Jun 26 2018, 6:16 PM
Stashbot added a comment.Jun 26 2018, 6:39 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-26T18:39:41Z] <marxarelli> setting $wmgUseMwEmbedSupport = false in php-1.32.0-wmf.10/LocalSettings.php to extension registry exception (see T197918 and T191056)

Stashbot mentioned this in T191056: 1.32.0-wmf.10 deployment blockers.Jun 26 2018, 6:39 PM
MarcoAurelio added a subscriber: • dduvall.Jun 27 2018, 8:33 PM

@dduvall Hello. I see this task is listed as blocker of a MediaWiki train. Please let us know if this is still an issue so we can remove and archive the extension where required. Thank you.

Jdforrester-WMF removed a parent task: T191056: 1.32.0-wmf.10 deployment blockers.Jun 27 2018, 9:24 PM
gerritbot added a comment.Jun 28 2018, 11:26 PM

Change 443006 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] [MwEmbedHandler] Archive

https://gerrit.wikimedia.org/r/443006

Jdforrester-WMF updated the task description. (Show Details)Jun 28 2018, 11:28 PM
• Vvjjkkii renamed this task from Archive the MwEmbedSupport extension to lhaaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii changed the task status from Stalled to Open.
• Vvjjkkii removed MarcoAurelio as the assignee of this task.
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, MarcoAurelio, Aklapper.
MarcoAurelio renamed this task from lhaaaaaaaa to Archive the MwEmbedSupport extension.Jul 2 2018, 9:57 AM
MarcoAurelio changed the task status from Open to Stalled.
MarcoAurelio claimed this task.
MarcoAurelio lowered the priority of this task from High to Low.
MarcoAurelio updated the task description. (Show Details)
MarcoAurelio removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser, Patch-For-Review.
MarcoAurelio moved this task from later/stalled/blocked to unsorted/backlog on the User-MarcoAurelio board.Jul 2 2018, 4:40 PM
MarcoAurelio moved this task from unsorted/backlog to later/stalled/blocked on the User-MarcoAurelio board.
MarcoAurelio added a comment.Jul 8 2018, 9:35 PM

@Jdforrester-WMF Was this extension undeployed already? Can we archive it? Thanks.

Krinkle subscribed.EditedJul 8 2018, 10:02 PM

As long as the placeholder files extension.json and MwEmbedSupport.php remain, archiving can proceed.

These files are kept for compatibility, similar to mediawiki/extensions/Vector.

gerritbot added a comment.Jul 10 2018, 6:38 PM

Change 443006 merged by jenkins-bot:
[integration/config@master] [MwEmbedSupport] Archive

https://gerrit.wikimedia.org/r/443006

Jdforrester-WMF updated the task description. (Show Details)Jul 10 2018, 6:44 PM
Jdforrester-WMF updated the task description. (Show Details)Jul 10 2018, 6:54 PM
Jdforrester-WMF updated the task description. (Show Details)Jul 10 2018, 7:50 PM
Liuxinyu970226 mentioned this in MediaWiki-extensions-MwEmbedSupport.Jul 18 2018, 5:13 AM
Liuxinyu970226 updated the task description. (Show Details)Jul 18 2018, 5:21 AM
Liuxinyu970226 updated the task description. (Show Details)
TheDJ subscribed.Aug 1 2018, 12:05 PM

Please take note that the extension is still in use by pre 1.32. It can be confusing for LTS users who need the old version:
https://www.mediawiki.org/wiki/Topic:Uhzp5n14nuojtfxb.

MarcoAurelio lowered the priority of this task from Low to Lowest.Aug 1 2018, 6:09 PM
Mainframe98 mentioned this in T190671: Identify archived extensions on mediawiki.org but not on Gerrit (and viceversa).Aug 5 2018, 10:58 AM
Umherirrender subscribed.Aug 7 2018, 3:56 PM
In T197918#4468782, @TheDJ wrote:

Please take note that the extension is still in use by pre 1.32. It can be confusing for LTS users who need the old version:
https://www.mediawiki.org/wiki/Topic:Uhzp5n14nuojtfxb.

It also confused CI on release branches. Would be nice to keep the dependency for pre-1.32 branches
https://gerrit.wikimedia.org/r/#/c/integration/config/+/443005/ was the remove

Krinkle unsubscribed.Aug 7 2018, 3:58 PM
gerritbot added a comment.Aug 7 2018, 7:52 PM

Change 451093 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions@master] Remove MwEmbedSupport

https://gerrit.wikimedia.org/r/451093

gerritbot added a project: Patch-For-Review.Aug 7 2018, 7:52 PM

Change 451093 merged by Umherirrender:
[mediawiki/extensions@master] Remove MwEmbedSupport

https://gerrit.wikimedia.org/r/451093

Umherirrender updated the task description. (Show Details)Aug 7 2018, 7:53 PM
MarcoAurelio added a comment.Aug 25 2018, 12:31 PM

Just for the sake of clarity (& talking about the code in the 'master' branch, as archiving doesn't happen on REL branches). Can we safely proceed to finally archive this or do you still need to keep the extension.json and the PHP empty entry point? Regards.

MarcoAurelio mentioned this in T62295: Namespace mw.MwEmbedSupport methods.Aug 25 2018, 12:34 PM
MarcoAurelio added a comment.Aug 25 2018, 12:37 PM

Project archived. One task closed and the other left open as it's also tagged with TimedMediaHandler and has a patch for review.

MarcoAurelio updated the task description. (Show Details)Aug 25 2018, 12:37 PM
Jdforrester-WMF added a comment.Aug 27 2018, 3:54 PM
In T197918#4532250, @MarcoAurelio wrote:

Just for the sake of clarity (& talking about the code in the 'master' branch, as archiving doesn't happen on REL branches). Can we safely proceed to finally archive this or do you still need to keep the extension.json and the PHP empty entry point? Regards.

We can. REL1_31 now doesn't depend on this, and the TMH volunteer community (such as it is) doesn't do support for releases anyway.

gerritbot added a comment.Aug 28 2018, 8:52 AM

Change 455778 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/MwEmbedSupport@master] Archive the MwEmbedSupport extension

https://gerrit.wikimedia.org/r/455778

MarcoAurelio changed the task status from Stalled to Open.Aug 28 2018, 10:56 AM

Un-stalling then. Patch for review on marking the extension as archived.

gerritbot added a comment.Aug 28 2018, 4:44 PM

Change 455778 merged by Jforrester:
[mediawiki/extensions/MwEmbedSupport@master] Archive the MwEmbedSupport extension

https://gerrit.wikimedia.org/r/455778

MarcoAurelio updated the task description. (Show Details)Aug 28 2018, 4:44 PM
MarcoAurelio updated the task description. (Show Details)Aug 28 2018, 6:19 PM
Stashbot added a comment.Aug 30 2018, 7:38 PM

Mentioned in SAL (#wikimedia-releng) [2018-08-30T19:37:59Z] <Hauskatze> github: deleted mirror of extension-MwEmbedSupport per T197918

MarcoAurelio closed this task as Resolved.Aug 30 2018, 7:38 PM
MarcoAurelio updated the task description. (Show Details)
MarcoAurelio removed a project: Patch-For-Review.

Requiescat in pace, MwEmbedSupport.

MarcoAurelio mentioned this in T203245: Recreate MwEmbedSupport on github.Aug 31 2018, 1:10 PM
MarcoAurelio moved this task from later/stalled/blocked to cabinet on the User-MarcoAurelio board.Sep 22 2018, 9:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL