Maniphest T197935

Multiple grep results in one line displayed incorrectly
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Dvorapa
	Jun 22 2018, 10:03 AM

Description

Steps to reproduce

Open any project
Search some pattern you know it matches in some file twice on one line

Event Timeline

Dvorapa created this task.Jun 22 2018, 10:03 AM

Restricted Application added a project: Upstream. · View Herald TranscriptJun 22 2018, 10:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Dvorapa edited projects, added Phabricator; removed Phabricator (Upstream).Jun 22 2018, 10:04 AM

Dvorapa edited projects, added Phabricator (Upstream); removed Phabricator.

What does this even mean?

Dvorapa updated the task description. (Show Details)Jun 22 2018, 10:09 AM

@Dvorapa: Please follow https://mediawiki.org/wiki/How_to_report_a_bug and structure tasks that you report by: 1) clear steps to reproduce that include example URLs, 2) expected outcome, 3) actual outcome. Thanks.

On https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/?grep=str there are a few files with str multiple times in the same line. But Phabricator mangles the display of them:

Screenshot from 2018-06-22 16-04-57.png (186×590 px, 9 KB)

Compare to the actual content on https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/docs/api_ref/tests/index.rst$35

I think I first noticed on Czech projects localisation (compare line 54 to the actual line content), but it can be reproduced on any project.

I think I described it properly in the description and title, maybe my English is not as good as it could be

Dvorapa renamed this task from Multiple grep results in one line wrongly highlighted to Multiple grep results in one line displayed incorrectly.Jun 22 2018, 2:37 PM

Dvorapa updated the task description. (Show Details)

Aklapper triaged this task as Lowest priority.Jun 22 2018, 3:56 PM

• Vvjjkkii renamed this task from Multiple grep results in one line displayed incorrectly to 4gaaaaaaaa.Jul 1 2018, 1:02 AM

• Vvjjkkii raised the priority of this task from Lowest to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 4gaaaaaaaa to Multiple grep results in one line displayed incorrectly.Jul 2 2018, 10:55 AM

CommunityTechBot lowered the priority of this task from High to Lowest.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

I noted this on https://secure.phabricator.com/T13339, which is not exactly adjacent but sort of has similar flavor and is somewhere in the pipeline.

This should be resolved upstream by https://secure.phabricator.com/D20695.

Cool!

Closing as per last comment. Please re-open if this still happens. Thanks!

	F22482929: Screenshot from 2018-06-22 16-04-57.png
	Jun 22 2018, 2:06 PM

Multiple grep results in one line displayed incorrectlyClosed, ResolvedPublicActions

Description

Event Timeline

Multiple grep results in one line displayed incorrectly
Closed, ResolvedPublic
Actions