Page MenuHomePhabricator

Normalize script names
Closed, DeclinedPublic

Description

Some scripts use underline in their names others dont, it would be good to have the names standardized one way or another so the names are in expected format and the user doesnt have to look them up before running them.

Changes to possibly affected scripts (removing underline):

add_text.py              →  addtext.py                 
capitalize_redirects.py  →  capitalizeredirects.py     
category_redirect.py     →  categoryredirect.py        
clean_sandbox.py         →  cleansandbox.py            
commons_link.py          →  commonslink.py             
coordinate_import.py     →  coordinateimport.py        
cosmetic_changes.py      →  cosmeticchanges.py         
create_categories.py     →  createcategories.py        
data_ingestion.py        →  dataingestion.py           
fixing_redirects.py      →  fixingredirects.py         
harvest_template.py      →  harvesttemplate.py         
illustrate_wikidata.py   →  illustratewikidata.py      
imagecopy_self.py        →  imagecopyself.py           
match_images.py          →  matchimages.py             
replicate_wiki.py        →  replicatewiki.py           
script_wui.py            →  scriptwui.py               
solve_disambiguation.py  →  solvedisambiguation.py     
standardize_interwiki.py →  standardizeinterwiki.py    
states_redirect.py       →  statesredirect.py          
surnames_redirects.py    →  surnamesredirects.py

Changes to possibly affected scripts (adding underline):

blockpageschecker.py     →  block_pages_checker.py     
casechecker.py           →  case_checker.py            
checkimages.py           →  check_images.py            
editarticle.py           →  edit_article.py            
flickrripper.py          →  flickr_ripper.py           
followlive.py            →  follow_live.py             
freebasemappingupload.py →  freebase_mapping_upload.py 
imagecopy.py             →  image_copy.py              
imageharvest.py          →  image_harvest.py           
imagerecat.py            →  image_recat.py             
imagetransfer.py         →  image_transfer.py          
imageuncat.py            →  image_uncat.py             
listpages.py             →  list_pages.py              
lonelypages.py           →  lonely_pages.py            
makecat.py               →  make_cat.py                
movepages.py             →  move_pages.py              
newitem.py               →  new_item.py                
noreferences.py          →  no_references.py           
nowcommons.py            →  now_commons.py             
pagefromfile.py          →  page_from_file.py          
spamremove.py            →  spam_remove.py             
template_count.py        →  templatecount.py           
unusedfiles.py           →  unused_files.py            
weblinkchecker.py        →  weblink_checker.py         
wikisourcetext.py        →  wikisource_text.py

Related Objects

StatusSubtypeAssignedTask
DeclinedXqt
OpenNone

Event Timeline

This would be a breaking change when operators use batch scripts for example. Is there an idea how to solve it? As long as the pwb wrapper is used instead of a side package installation, a reference dict would help to solve it. But what about side package users?

Xqt triaged this task as Lowest priority.Jun 23 2018, 11:47 AM
Vvjjkkii renamed this task from Normalize script names to dfaaaaaaaa.Jul 1 2018, 1:02 AM
Vvjjkkii raised the priority of this task from Lowest to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
JJMC89 renamed this task from dfaaaaaaaa to Normalize script names.Jul 1 2018, 4:40 AM
JJMC89 lowered the priority of this task from High to Lowest.
JJMC89 updated the task description. (Show Details)

Change 444437 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Normalize script names

https://gerrit.wikimedia.org/r/444437

Change 444437 abandoned by Xqt:
[IMPR] Normalize script names

https://gerrit.wikimedia.org/r/444437

Xqt added a subscriber: Mpaa.

Declined due to no consens found on CR until now and every change on any script will cause the patch to be rebased. Too many work for a little benefit.

But the main reason for declining the request is that pwb.py wrapper script is able to start similar written script names and it doesn't matter a lot whether you start the script with

  • pwb add_text
  • pwb addtext
  • pwb addtest
  • pwb add_my_text

It always starts the right thing and the user doesnt have to look them up before running them anymore.