Page MenuHomePhabricator

[Bug] Gallery next / previous buttons click area too narrow
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to Reproduce

  1. Visit https://en.m.wikipedia.org/wiki/Sublime_(philosophy)#/media/File%3ASMSMS.JPG
  2. From the center towards the left, start tapping.

Expected Results

  • A generous width considering percentage is given to the gallery navigation buttons; e.g.:
min-width: 40px;
width: 10%;
max-width: 80px;

Screenshot from 2018-06-23 11-55-05.png (883×929 px, 264 KB)

Actual Results

  • A generous height but a very narrow width with an unexpectedly minimal margin is offered even on large displays.

Screenshot from 2018-06-23 11-55-26.png (883×929 px, 265 KB)

Environments Observed

Browser Version

  • Chromium v66.0.3359.181

OS Version

  • Ubuntu v18.04

Device Model

  • Desktop

Device Language

  • English

Acceptance criteria

  • Touch area has been increased to 60px width per @alexhollender recommendation.
  • There is an inline comment explaining why 60px has been chosen in case attempts are made to change it again later.
  • No change to height is necessary

QA

Environment: staging
Browser & device: mobile grade A browsers & desktop grade A browsers
Skin: minerva
Steps:

  1. Go to https://readers-web-staging.wmflabs.org/wiki/A?mobileaction=toggle_view_mobile#/media/File%3AA_cursiva.gif
  2. Check that left and right arrow buttons are easily clickable/tappable. They should have a target size of at least 60px in width.

Event Timeline

Any problems here @alexhollender with the experience? Previously a decision was made that the entire left/right side would be clickable. I forget why though. 40px width meets the advised tap area for touch phones.

Vvjjkkii renamed this task from [Bug] Gallery next / previous buttons click area too narrow to teaaaaaaaa.Jul 1 2018, 1:02 AM
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from teaaaaaaaa to [Bug] Gallery next / previous buttons click area too narrow.Jul 2 2018, 10:29 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.

I think increasing to 60px width would be nice :)

Screen Shot 2018-09-17 at 12.12.19 PM.png (831×861 px, 893 KB)

Screen Shot 2018-09-17 at 12.12.41 PM.png (693×695 px, 411 KB)

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptSep 17 2018, 4:13 PM
ovasileva set the point value for this task to 1.Sep 18 2018, 4:47 PM
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.

Change 461820 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Increase touch area for Image Overlay next / prev buttons

https://gerrit.wikimedia.org/r/461820

Change 461820 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Increase touch area for Image Overlay next / prev buttons

https://gerrit.wikimedia.org/r/461820

Jdlrobson added a subscriber: nray.

On staging.. take a look!

nray updated the task description. (Show Details)

also, props to @nray for adding QA instructions : )

Looks good to me, checked on a very narrow screen (iPhone5s). I think it's easily clickable/tappable.

ovasileva updated the task description. (Show Details)
ovasileva subscribed.

All done here!