Maniphest T198044

Short-circuit VersionChecker checks if the version constraint is '*'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Jun 24 2018, 9:25 PM

Project Tags

Referenced Files

None

Subscribers

Description

We can probably skip a bunch of checks if the version dependency is * since we just need to check that the name is loaded.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	registration: Short-circuit if dependency constraint is '*'	mediawiki/core	master	+11 -15

Customize query in gerrit

Event Timeline

Legoktm created this task.Jun 24 2018, 9:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2018, 9:25 PM

• Vvjjkkii renamed this task from Short-circuit VersionChecker checks if the version constraint is '*' to 3daaaaaaaa.Jul 1 2018, 1:02 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 3daaaaaaaa to Short-circuit VersionChecker checks if the version constraint is '*'.Jul 2 2018, 10:23 AM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Change 455905 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] registration: Short-circuit if dependency constraint is '*'

https://gerrit.wikimedia.org/r/455905

gerritbot added a project: Patch-For-Review.Aug 28 2018, 7:30 PM

Legoktm claimed this task.Aug 28 2018, 7:31 PM

Legoktm added a project: Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).

Legoktm moved this task from Backlog to Waiting for Review on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.

Change 455905 merged by jenkins-bot:
[mediawiki/core@master] registration: Short-circuit if dependency constraint is '*'

https://gerrit.wikimedia.org/r/455905

Legoktm closed this task as Resolved.Aug 28 2018, 8:34 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 28 2018, 9:00 PM

• CCicalese_WMF moved this task from Waiting for Review to Closed on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Oct 1 2018, 12:39 PM

Short-circuit VersionChecker checks if the version constraint is '*'Closed, ResolvedPublicActions

Description

Details

Event Timeline

Short-circuit VersionChecker checks if the version constraint is '*'
Closed, ResolvedPublic
Actions