Page MenuHomePhabricator
Create Task
Maniphest T198054

Invalid language code on Special:UserLogin leads to internal error
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

When you login on https://www.mediawiki.org/wiki/Special:UserLogin?uselang=/ with the invalid language code / you get an internal error.

The problematic code in includes/specialpage/LoginSignupSpecialPage.php is

$code = $this->getRequest()->getVal( 'uselang', $user->getOption( 'language' ) );
$userLang = Language::factory( $code );

because Language::factory throws an exception on an invalid language code.

Expected behavior: Ignore the invalid language code or show an explicit error message.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
specialpage: Fix login crash caused by unknown language via ?uselangKrinklemediawiki/coreREL1_32+3 -4
LoginSignupSpecialPage: Fallback to content language on invalid language codeFomafixmediawiki/coremaster+3 -2
specialpage: Fix login crash caused by unknown language via ?uselangD3r1ck01mediawiki/coremaster+3 -4
specialpage: Fix login crash caused by unknown language via ?uselangD3r1ck01mediawiki/coremaster+15 -2
Customize query in gerrit

Related Objects

Event Timeline

Fomafix created this task.Jun 25 2018, 7:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2018, 7:04 AM
gerritbot subscribed.Jun 25 2018, 7:15 AM

Change 441771 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] LoginSignupSpecialPage: Fallback to $wgContLang on invalid language code

https://gerrit.wikimedia.org/r/441771

gerritbot added a project: Patch-For-Review.Jun 25 2018, 7:15 AM
• Vvjjkkii renamed this task from Invalid language code on Special:UserLogin leads to internal error to tdaaaaaaaa.Jul 1 2018, 1:01 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
JJMC89 renamed this task from tdaaaaaaaa to Invalid language code on Special:UserLogin leads to internal error.Jul 1 2018, 3:00 AM
JJMC89 raised the priority of this task from High to Needs Triage.
JJMC89 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
JJMC89 updated the task description. (Show Details)
JJMC89 added a subscriber: Aklapper.
Krinkle closed this task as Resolved.Sep 19 2018, 3:17 PM
Krinkle edited projects, added: Wikimedia-production-error; removed: Patch-For-Review.
Krinkle subscribed.

It seems this was resolved. Urls https://www.mediawiki.org/wiki/Special:UserLogin?uselang=/ and https://www.mediawiki.org/w/index.php?title=Special:UserLogin&uselang=fo_o do not produce an error at this time.

Krinkle mentioned this in T204833: Fatal error on Special:Translate for certain 'language' values.Sep 19 2018, 3:33 PM
Fomafix reopened this task as Open.Sep 19 2018, 3:43 PM

Reopened. The error still exist.

This I get after I login on https://www.mediawiki.org/wiki/Special:UserLogin?uselang=/

grafik.png (1,020×454 px, 109 KB)

Krinkle added a comment.Sep 19 2018, 4:08 PM

Interesting. I don't.

Screen Shot 2018-09-19 at 17.08.04.png (990×744 px, 132 KB)

Fomafix added a comment.EditedSep 19 2018, 4:10 PM

Steps to reproduce:

Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.Sep 19 2018, 4:13 PM

Thanks. So the problem is as follows:

  • When presenting the log-in form, the unknown uselang value is validated and replaced with a valid one (e.g. fallback to 'en').
  • Hidden inside the form, the original unknown value is preserved.
  • When we respond to a successful log-in form submission, the unknown value is seen a second time, but this time the code forgets to validate/normalise it. Resulting in the crash!
gerritbot added a comment.Jan 24 2019, 5:04 PM

Change 486327 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] specialpage: Fix login crash caused by unknown language via ?uselang

https://gerrit.wikimedia.org/r/486327

gerritbot added a project: Patch-For-Review.Jan 24 2019, 5:04 PM
xSavitar claimed this task.Jan 24 2019, 5:34 PM
xSavitar triaged this task as Medium priority.
xSavitar added a project: User-xSavitar.Jan 24 2019, 5:37 PM
xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.
xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.Jan 24 2019, 8:07 PM
gerritbot added a comment.Jan 25 2019, 9:57 PM

Change 486693 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] specialpage: Fix login crash caused by unknown language via ?uselang

https://gerrit.wikimedia.org/r/486693

gerritbot added a comment.Jan 28 2019, 10:06 AM

Change 486327 abandoned by D3r1ck01:
specialpage: Fix login crash caused by unknown language via ?uselang

Reason:
In favor of: I825fdf

https://gerrit.wikimedia.org/r/486327

gerritbot added a comment.Feb 5 2019, 1:33 AM

Change 486693 merged by jenkins-bot:
[mediawiki/core@master] specialpage: Fix login crash caused by unknown language via ?uselang

https://gerrit.wikimedia.org/r/486693

gerritbot added a comment.Feb 5 2019, 1:36 AM

Change 487977 had a related patch set uploaded (by Krinkle; owner: Derick Alangi):
[mediawiki/core@REL1_32] specialpage: Fix login crash caused by unknown language via ?uselang

https://gerrit.wikimedia.org/r/487977

Krinkle closed this task as Resolved.Feb 5 2019, 1:36 AM
Krinkle removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Feb 5 2019, 2:00 AM
gerritbot added a comment.Feb 5 2019, 2:04 AM

Change 441771 abandoned by Fomafix:
LoginSignupSpecialPage: Fallback to content language on invalid language code

Reason:
Superseded by 34f78a69ef058c19ecdac7290a174624ef8212ee (https://gerrit.wikimedia.org/r/486693)

https://gerrit.wikimedia.org/r/441771

gerritbot added a comment.Feb 5 2019, 10:07 PM

Change 487977 merged by jenkins-bot:
[mediawiki/core@REL1_32] specialpage: Fix login crash caused by unknown language via ?uselang

https://gerrit.wikimedia.org/r/487977

ReleaseTaggerBot added a project: MW-1.32-notes.Feb 5 2019, 11:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits