| Trizek-WMF | |
| Jun 25 2018, 8:43 AM |
| F22624051: Capture d’écran_2018-06-25_10-37-02.png | |
| Jun 25 2018, 8:43 AM |
When you edit a link to remove it, visualeditor-clearbutton-tooltip ("clear styling") is used as a label on the button that removes links:
This has confused a user feeling uncomfortable with the visual editing interface during a workshop I was leading.
A more clear label should be used, like "removing link".
Side note, if a user wants to clear styling on a bolded link, using that "clear styling" button will not do the expected: the link will be removed, not the bold.
Note that this is totally my fault from back in 2015 with 7ecde6c05.
Arguably, it shouldn't be "clear styling" for any situation where this currently appears, not just links. This button only appears on things which explicitly extend AnnotationContextItem, which is links and languages. It's a case of "clear styling" making sense for a hypothetical generic annotation context, and then not making sense for any place we actually use it.
That said, it's incredibly easy to override. There's a static property clearMsg which just needs to be set on the relevant subclasses.
What shall we set the message to? Google uses "remove formatting", which is better than "clear styling", though it's still not ideal… but I also can't think of anything better.
I'd say:
(I said it's my fault because James asked me to do those overrides in the original patch, and I missed them.)
@DLynch, from an user perspective, the 3 options seems reasonable. Thank you for taking care of that!
Change 442756 had a related patch set uploaded (by Annayoungyeun; owner: Annayoungyeun):
[VisualEditor/VisualEditor@master] Change clear styling label in contexts
From gerrit:
I'd just make this (the default message) 'Remove', for example the comment annotation isn't really 'formatting' and it's clear from the context what it is removing.
Change 442756 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Change clear styling label in contexts
Change 444139 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbe825690)
Change 444139 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbe825690)
Well right now, I see raw message keys for both "remove link" and "remove language".
visualeditor-linkcontext-remove and visualeditor-languagecontext-remove,
Change 445037 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Follow-up dfe27be: Add missing i18n keys to manifest
Change 445037 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Follow-up dfe27be: Add missing i18n keys to manifest
Change 445044 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.12] Follow-up dfe27be: Add missing i18n keys to manifest
Change 445044 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.12] Follow-up dfe27be: Add missing i18n keys to manifest
Mentioned in SAL (#wikimedia-operations) [2018-07-12T23:32:14Z] <jforrester@deploy1001> Synchronized php-1.32.0-wmf.12/extensions/VisualEditor: SWAT VisualEditor: Add missing i18n keys to manifest T198064 (duration: 00m 52s)