Page MenuHomePhabricator
Create Task
Maniphest T198075

Factoring page update logic out of WikiPage
Open, Needs TriagePublic
Actions

Description

As part of implementing Multi-Content-Revisions, a new PageUpdater interface was introduced into core, see T174038 (original spec: MCR Page Update Controller).

With the initial implementation merged, there is still a lot of legacy code to be refactored (tracked as T196087). The purpose of this RFC is to ensure agreement on the architecture we should target with this refactoring. An analysis of the current situation, our needs, and an overview of the future architecture can be found here:

https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/MCR-PageUpdater

This architecture is fairly high level, it does not discuss concrete interfaces or implementations. The architecture has already been vetted within the MCR team. This RFC is intended to ensure broad agreement on the big picture.

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenBUG REPORTNoneT12863 Links on commons upload summaries do not link to commons
 OpenNoneT5498 Image history is confusing
 StalledNoneT96384 Integrate file revisions with description page history
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 OpenNoneT122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
 OpenNoneT135221 Make TimedText content an integral part of the File page
 OpenFeatureNoneT2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
 OpenNoneT132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenFeatureNoneT14963 allow per-page exceptions to spam blacklist
 OpenNoneT203157 Make the spam whitelist its own slot
 OpenFeatureNoneT56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
 StalledNoneT174043 Deploy Multi-Content Revisions
 OpenNoneT174022 Implement multi-content revisions
 OpendanielT196087 Refactored implementation of MCR page update interface
 OpenNoneT198075 Factoring page update logic out of WikiPage

Event Timeline

daniel created this task.Jun 25 2018, 10:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2018, 10:16 AM
daniel added projects: Multi-Content-Revisions, TechCom-RFC.Jun 25 2018, 10:16 AM
daniel moved this task from P1: Define to Request IRC meeting on the TechCom-RFC board.

As per last week's TechCom meeting, this RFC is scheduled for discussion on IRC for Wednesday, June 27. This discussion will take place in the #wikimedia-office channel at 21:00 UTC (23:00 CEST, 2pm PDT ).

daniel added a project: MediaWiki-Platform-Team-Archived.Jun 25 2018, 10:19 AM
daniel added subscribers: CCicalese_WMF, Anomie, Tgr, Addshore.
daniel added a parent task: T196087: Refactored implementation of MCR page update interface.Jun 25 2018, 10:51 AM
daniel renamed this task from RFC: factoring page update logic out of WIkiPage to RFC: factoring page update logic out of WiIkiPage.Jun 25 2018, 11:19 AM
daniel mentioned this in T190063: Tracking dependencies for multiple Content objects per page (MCR).
Ltrlg renamed this task from RFC: factoring page update logic out of WiIkiPage to RFC: factoring page update logic out of WikiPage.Jun 26 2018, 10:30 AM
• kchapman subscribed.Jun 27 2018, 9:59 PM

TechCom hosted a RFC meeting about this.

Minutes: https://tools.wmflabs.org/meetbot/wikimedia-office/2018/wikimedia-office.2018-06-27-21.00.html
Log: https://tools.wmflabs.org/meetbot/wikimedia-office/2018/wikimedia-office.2018-06-27-21.00.log.html

It was agreed that the EditController concept is approved

• Vvjjkkii renamed this task from RFC: factoring page update logic out of WikiPage to 8caaaaaaaa.Jul 1 2018, 1:01 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
JJMC89 renamed this task from 8caaaaaaaa to RFC: factoring page update logic out of WikiPage.Jul 1 2018, 3:41 AM
JJMC89 raised the priority of this task from High to Needs Triage.
JJMC89 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
JJMC89 updated the task description. (Show Details)
JJMC89 added a subscriber: Aklapper.
• tstarling moved this task from Inbox to Watching on the MediaWiki-Platform-Team-Archived board.Jul 3 2018, 1:20 AM
daniel moved this task from Request IRC meeting to Under discussion on the TechCom-RFC board.Jul 4 2018, 8:14 PM
Osnard subscribed.Jul 9 2018, 9:17 AM
CCicalese_WMF edited projects, added Core-Platform-Team-Old; removed MediaWiki-Platform-Team-Archived.Jul 12 2018, 12:06 AM
CCicalese_WMF moved this task from Inbox to CPT MCR Backlog on the Core-Platform-Team-Old board.Jul 12 2018, 12:09 AM
daniel mentioned this in T200880: Editor should flag mobile editing warnings.Aug 8 2018, 7:23 PM
CCicalese_WMF added a project: Platform Team Legacy (Next).Oct 1 2018, 11:24 PM
CCicalese_WMF edited projects, added Core Platform Team Goals (MCR: Uncategorized); removed Core-Platform-Team-Old.Oct 2 2018, 12:10 AM
CCicalese_WMF edited projects, added Platform Engineering (MCR: Deployment); removed Core Platform Team Goals (MCR: Uncategorized).Oct 2 2018, 2:47 AM
CCicalese_WMF moved this task from MCR: Deployment to MCR on the Platform Engineering board.Oct 2 2018, 3:14 AM
CCicalese_WMF edited projects, added Platform Engineering (MCR); removed Platform Engineering (MCR: Deployment).
CCicalese_WMF moved this task from Inbox to Next on the Multi-Content-Revisions board.Oct 3 2018, 2:59 PM
CCicalese_WMF moved this task from Next to Tech Debt on the Multi-Content-Revisions board.Oct 4 2018, 2:59 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (Tech Debt); removed Multi-Content-Revisions.
Krinkle moved this task from Under discussion to Old on the TechCom-RFC board.Mar 20 2019, 7:57 PM
Krinkle subscribed.

@daniel This could do with a more concrete problem statement, and one or more stakeholders/affected parties we want to hear from at minimum.

• kchapman moved this task from Next to Later on the Platform Team Legacy board.Mar 26 2019, 2:52 PM
• kchapman edited projects, added Platform Team Legacy (Later); removed Platform Team Legacy (Next).
WDoranWMF moved this task from Later to Mop Column on the Platform Team Legacy board.Jul 5 2019, 2:08 PM
WDoranWMF removed a project: Platform Team Legacy (Later).
WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:37 PM
WDoranWMF edited projects, added Platform Team Initiatives (MCR); removed Platform Engineering (MCR).
Krinkle renamed this task from RFC: factoring page update logic out of WikiPage to Factoring page update logic out of WikiPage.Sep 16 2020, 7:23 PM
Krinkle removed a project: TechCom-RFC.

Untagging old RFC task that predates our current process. Feel free to retag if it is still meant as RFC, including the template in the task description.

Tgr added a comment.Sep 17 2020, 12:24 AM

I think this was largely about creating DerivedPageDataUpdater which has been done, so the task can be resolved, but maybe @daniel has more accurate recollections.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:01 PM
Aklapper added a comment.Feb 19 2021, 9:03 AM
In T198075#6468829, @Tgr wrote:

I think this was largely about creating DerivedPageDataUpdater which has been done, so the task can be resolved, but maybe @daniel has more accurate recollections.

@daniel: Any opinion?

daniel added a comment.Feb 19 2021, 2:19 PM
In T198075#6468829, @Tgr wrote:

I think this was largely about creating DerivedPageDataUpdater which has been done, so the task can be resolved, but maybe @daniel has more accurate recollections.

This is about the refactoring outlined in https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/MCR-PageUpdater. DerivedPageDataUpdater already existed when this ticket was created.

Addshore unsubscribed.Jun 27 2023, 12:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL