Page MenuHomePhabricator
Create Task
Maniphest T198114

Allow tool maintainers to delete toolinfo via ToolsAdmin
Closed, ResolvedPublic
Actions

Description

Mail conversation between @Urbanecm and @bd808

On Sat, Jun 23, 2018 at 6:39 AM, Martin Urbanec
<martin.urbanec@wikimedia.cz> wrote:
> Hello Bryan,
>
> how can I delete a toolinfo file I created via Toolsadmin? I created
> https://toolsadmin.wikimedia.org/tools/id/harvesting-data-rafinery/info/id/360/edit
> and
> https://toolsadmin.wikimedia.org/tools/id/harvesting-data-refinery/info/id/373/edit
> which were duplicates to each other. The lattter is up to date, under
> correct tool with correct spelling and the first should be deleted somehow.
> I don't see this possibility in Toolsadmin.

I don't remember adding a delete function, so there probably is not
one. Can you create a phabricator task for this and tag it with the
#striker project?

Bryan

Details

SubjectRepoBranchLines +/-
2020-09-02 releaselabs/striker/deploymaster+84 -51
Add ability to delete toolinfo recordslabs/strikermaster+115 -6
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Jun 25 2018, 3:12 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJun 25 2018, 3:12 PM
Urbanecm moved this task from Backlog to Watching on the User-Urbanecm board.Jun 25 2018, 3:13 PM
• Vvjjkkii renamed this task from Allow tool maintainers to delete toolinfo via ToolsAdmin to 5baaaaaaaa.Jul 1 2018, 1:01 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
ToBeFree updated the task description. (Show Details)Jul 1 2018, 2:37 AM
Krenair updated the task description. (Show Details)Jul 1 2018, 2:38 AM
JJMC89 renamed this task from 5baaaaaaaa to Allow tool maintainers to delete toolinfo via ToolsAdmin.Jul 1 2018, 2:39 AM
JJMC89 raised the priority of this task from High to Needs Triage.
JJMC89 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
JJMC89 added a subscriber: Aklapper.
Urbanecm removed a project: User-Urbanecm.Oct 10 2018, 11:08 AM
• GTirloni added a project: cloud-services-team (Kanban).Mar 24 2019, 11:01 AM
jberkel subscribed.Apr 10 2019, 1:46 PM
bd808 removed a project: cloud-services-team (Kanban).Jul 9 2019, 9:30 PM
Lokal_Profil subscribed.Aug 18 2019, 12:24 PM
DSquirrelGM subscribed.Feb 3 2020, 4:10 AM
DSquirrelGM added a comment.Feb 3 2020, 4:25 AM

Until this is resolved, perhaps marking the records with an "unlisted" tag and adding a script or style to the list pages to hide records containing those tags might be a reasonable temporary measure.

bd808 added a comment.Jul 24 2020, 12:24 AM

I'm trying to decide if the delete action should actually be a hard delete of the record from the database or if we should take a more wiki-like approach and make delete toggle a status on the backing record that would allow it to be undeleted at some point if desired. A plain delete is likely less implementation work, but I'm not sure how user friendly it would be. If we do go with a full delete there should be a confirmation required of the user to help protect against mis-clicked buttons.

bd808 triaged this task as Medium priority.Jul 24 2020, 12:24 AM
bd808 moved this task from Backlog to Needs Discussion on the Striker board.
Nintendofan885 subscribed.Jul 24 2020, 7:35 AM
bd808 moved this task from Needs Discussion to Doing on the Striker board.Jul 28 2020, 10:57 PM
In T198114#6331615, @bd808 wrote:

I'm trying to decide if the delete action should actually be a hard delete of the record from the database or if we should take a more wiki-like approach and make delete toggle a status on the backing record that would allow it to be undeleted at some point if desired. A plain delete is likely less implementation work, but I'm not sure how user friendly it would be. If we do go with a full delete there should be a confirmation required of the user to help protect against mis-clicked buttons.

For now I decided to go with a full delete behind a confirmation screen. Getting the user interface right for soft deletes was more effort than I have time for right now. It seems better to allow deleting than to wait for time to design and implement a really nice user experience for undeleteing.

bd808 added a comment.Jul 28 2020, 11:04 PM
In T198114#6342930, @bd808 wrote:

For now I decided to go with a full delete behind a confirmation screen. Getting the user interface right for soft deletes was more effort than I have time for right now. It seems better to allow deleting than to wait for time to design and implement a really nice user experience for undeleteing.

It seems that the library I'm using for model versioning (used for diffs and reverts) keeps full history on delete too, so deleted toolinfo records will be recoverable, the UI for doing that is just missing in what I'm going to implement first. See https://django-reversion.readthedocs.io/en/stable/api.html#restoring-deleted-model-instances

gerritbot added a comment.Jul 28 2020, 11:20 PM

Change 616947 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker@master] Add ability to delete toolinfo records

https://gerrit.wikimedia.org/r/616947

gerritbot added a project: Patch-For-Review.Jul 28 2020, 11:20 PM
bd808 claimed this task.Jul 28 2020, 11:21 PM
Restricted Application added a project: User-bd808. · View Herald TranscriptJul 28 2020, 11:21 PM
gerritbot added a comment.Jul 31 2020, 5:40 PM

Change 616947 merged by jenkins-bot:
[labs/striker@master] Add ability to delete toolinfo records

https://gerrit.wikimedia.org/r/616947

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2020, 6:10 PM
bd808 moved this task from To Do to Needs Review/Feedback on the User-bd808 board.Aug 3 2020, 1:10 AM
gerritbot added a comment.Aug 28 2020, 11:34 PM

Change 623075 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker/deploy@master] Bump striker and wheels sub modules

https://gerrit.wikimedia.org/r/623075

gerritbot added a project: Patch-For-Review.Aug 28 2020, 11:34 PM
gerritbot added a comment.Sep 2 2020, 7:52 PM

Change 623075 merged by jenkins-bot:
[labs/striker/deploy@master] 2020-09-02 release

https://gerrit.wikimedia.org/r/623075

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2020, 8:11 PM
Stashbot mentioned this in T144111: Allow self-service creation of Maniphest projects for Tools.Sep 2 2020, 9:46 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-02T21:46:25Z] <bd808@deploy1001> Started deploy [striker/deploy@3c2090a]: Deploying r20200902 tag (T198114, T223610, T245804, T144111, T261810)

Stashbot mentioned this in T223610: Tool creation and toolinfo create/edit forms are the same causing confusion about field mutability/use.Sep 2 2020, 9:46 PM
Stashbot mentioned this in T245804: Reassign base URLs for toolinfo records' web service links.
Stashbot mentioned this in T261810: Striker not compatible with mwoauth>=0.3.5.

Mentioned in SAL (#wikimedia-operations) [2020-09-02T21:47:59Z] <bd808@deploy1001> Finished deploy [striker/deploy@3c2090a]: Deploying r20200902 tag (T198114, T223610, T245804, T144111, T261810) (duration: 01m 34s)

bd808 closed this task as Resolved.Sep 2 2020, 10:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL