With T197792 we're now expecting different headers for different content responses, but we're not testing this:
- check for an invalid absence of a vary or content-language header
- check that headers we didn't expect to be present were
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Leverage spec checks for checking response headers | mediawiki/services/mobileapps | master | +171 -236 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Implementation idea: it would be worth exploring whether what we need can be done entirely via response specifications in spec.js.
Comment Actions
Sounds good. Ideally next time please lets add tests with the patches that add the features. Tests and docs should be as first class as the code itself.
Comment Actions
Change 460004 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Leverage spec checks for checking headers
Comment Actions
Change 460004 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Leverage spec checks for checking response headers
Comment Actions
When the Accept-Language header stuff is ready we could also add an x-ample which triggers the vary header of the response having Accept-Language also.