Page MenuHomePhabricator

'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE
Closed, ResolvedPublic

Description

Resize the lede video on https://en.wikipedia.org/w/index.php?title=Trump_administration_family_separation_policy&oldid=847514790&veaction=edit

Note the thumbnail is now from 0 seconds, instead of 2 seconds.

Event Timeline

Change 442082 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Pass video thumbtime to thumbnail metadata request

https://gerrit.wikimedia.org/r/442082

Deskana triaged this task as Medium priority.
Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.
Deskana moved this task from Incoming to Code review on the VisualEditor (Current work) board.
Deskana added a subscriber: Deskana.

Please remember to put things in the code review column when you've got a patch ready. Thanks!

The same problem also affects other extension thumbnail parameters, e.g. page=N for PDF files:

[[File:The Sad, Sad Story of Social Wikipedia.pdf|thumb|page=3]]

The same problem also affects other extension thumbnail parameters, e.g. page=N for PDF files:

[[File:The Sad, Sad Story of Social Wikipedia.pdf|thumb|page=3]]

See T182392: After editing a multipage file VE incorrectly shows first page whilst editing (but shows the correct page after saving) (or merge it if you want to cover one task both cases).

Change 442082 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Pass video thumbtime to thumbnail metadata request

https://gerrit.wikimedia.org/r/442082

Vvjjkkii renamed this task from 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE to 5aaaaaaaaa.Jul 1 2018, 1:01 AM
Vvjjkkii removed Esanders as the assignee of this task.
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
ToBeFree renamed this task from 5aaaaaaaaa to 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE.Jul 1 2018, 2:34 AM
ToBeFree assigned this task to Esanders.
ToBeFree lowered the priority of this task from High to Medium.