⚓ T198150 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE

	Subject	Repo	Branch	Lines +/-
	Pass video thumbtime to thumbnail metadata request	mediawiki/extensions/VisualEditor	master	+24 -5

Esanders created this task.Jun 25 2018, 10:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2018, 10:39 PM

Change 442082 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Pass video thumbtime to thumbnail metadata request

https://gerrit.wikimedia.org/r/442082

gerritbot added a project: Patch-For-Review.Jun 26 2018, 12:03 PM

Please remember to put things in the code review column when you've got a patch ready. Thanks!

matmarex added a project: VisualEditor-MediaWiki.Jun 26 2018, 8:16 PM

The same problem also affects other extension thumbnail parameters, e.g. page=N for PDF files:

[[File:The Sad, Sad Story of Social Wikipedia.pdf|thumb|page=3]]

matmarex mentioned this in T198103: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video .Jun 26 2018, 8:49 PM

In T198150#4317395, @matmarex wrote:
The same problem also affects other extension thumbnail parameters, e.g. page=N for PDF files:
[[File:The Sad, Sad Story of Social Wikipedia.pdf|thumb|page=3]]

See T182392: After editing a multipage file VE incorrectly shows first page whilst editing (but shows the correct page after saving) (or merge it if you want to cover one task both cases).

Change 442082 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Pass video thumbtime to thumbnail metadata request

https://gerrit.wikimedia.org/r/442082

matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Jun 29 2018, 8:21 PM

matmarex removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 8:01 PM

• Vvjjkkii renamed this task from 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE to 5aaaaaaaaa.Jul 1 2018, 1:01 AM

• Vvjjkkii removed Esanders as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

ToBeFree updated the task description. (Show Details)Jul 1 2018, 2:30 AM

ToBeFree edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

ToBeFree added subscribers: gerritbot, Aklapper.

ToBeFree renamed this task from 5aaaaaaaaa to 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE.Jul 1 2018, 2:34 AM

ToBeFree assigned this task to Esanders.

ToBeFree lowered the priority of this task from High to Medium.

• Deskana closed this task as Resolved.Jul 2 2018, 3:49 PM

'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE
Closed, ResolvedPublic
Actions

Description

Details

Related Objects

Event Timeline

'thumbtime' not preserved when re-generating view rendering of video thumbnail in VEClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE
Closed, ResolvedPublic
Actions