Maniphest T198151

Upgrade Thanks icon
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Jdlrobson
	Jun 25 2018, 10:59 PM

Description

Thanks uses an outdated PNG for an icon graphic. It also has issues with alignment.
Let's modernise this to an SVG to avoid this problem.

Screen Shot 2018-06-25 at 2.50.40 PM.png (123×141 px, 3 KB)

Acceptance criteria

Use mw-ui-icon for generating the icon
Update icon to new asset

Remove CSS code in MobileFrontend that workarounds the lack of usage of mw-ui-icon

QA steps

General QA of the thanks on diff feature - make sure you are happy with the icon and the behaviour.

Login and visit a diff e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/81611 or https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/381373
Thank the user

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Thanks	master	+44 -18	Do not use PNG for thanks button

Customize query in gerrit

Related Objects

Mentioned Here: T196758: Thanks button icon doesn't appear well on mobile

Event Timeline

• Jdlrobson created this task.Jun 25 2018, 10:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2018, 10:59 PM

• Jdlrobson added projects: Thanks, Technical-Debt.Jun 25 2018, 11:06 PM

• Jdlrobson updated the task description. (Show Details)

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 25 2018, 11:06 PM

• Jdlrobson added a project: Design (RW-Design-Debt).Jun 25 2018, 11:06 PM

ovasileva triaged this task as Medium priority.Jun 26 2018, 10:29 AM

ovasileva edited projects, added Readers-Web-Backlog (Design); removed Design (RW-Design-Debt), Readers-Web-Backlog.

The alignment issue was fixed in T196758: Thanks button icon doesn't appear well on mobile:

Screen Shot 2018-06-18 at 2.54.28 PM.png (242×286 px, 32 KB)

@Etonkovidova the fix for T198151 introduced some technical debt which I'm keen to remove (see third acceptance criteria) and having spoken to a few designers it looks like the icon is incorrect.
Newly proposed icon is this (but in white):

Screen Shot 2018-06-26 at 11.00.02 AM.png (117×150 px, 2 KB)

JTannerWMF moved this task from Untriaged to External on the Collaboration-Team-Triage board.Jun 26 2018, 6:00 PM

Change 440258 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Thanks@master] Do not use png for thanks button

https://gerrit.wikimedia.org/r/440258

gerritbot added a project: Patch-For-Review.Jun 27 2018, 11:13 PM

@alexhollender can you and @Volker_E confirm you are happy with the asset change?

I've been asking on the patch if the icon change is willingly done?
When looking at the location and the use case, your choice, @Jdlrobson, makes sense to me – it's even better than before as the result is signified with the same icon.

Only small restriction is that it's a rather complex icon for a button. But as this is a very special, rare use case, I'm for it.

• Vvjjkkii renamed this task from Upgrade Thanks icon to 4aaaaaaaaa.Jul 1 2018, 1:01 AM

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

JJMC89 renamed this task from 4aaaaaaaaa to Upgrade Thanks icon.Jul 1 2018, 3:04 AM

JJMC89 lowered the priority of this task from High to Medium.

JJMC89 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

JJMC89 updated the task description. (Show Details)

JJMC89 added a subscriber: Aklapper.

Change 440258 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Do not use PNG for thanks button

https://gerrit.wikimedia.org/r/440258

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 9 2018, 10:37 PM

An old patch got merged so adding to the kanbana board to go through our process.
@alexhollender assigning to you for design review.

• Jdlrobson assigned this task to • alexhollender_WMF.Aug 9 2018, 10:40 PM

• Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

• Jdlrobson updated the task description. (Show Details)Aug 9 2018, 10:42 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 9 2018, 11:00 PM

ovasileva moved this task from Triaged but Future to Current Sprint (and resolved 2018-19 Q1) pre-milestone on the Readers-Web-Backlog board.Aug 10 2018, 1:43 PM

Checked with iOS and Android - works/looks as expected.

Just as a side note - the previous icon was visually consistent with the user icon: dark background and white face elements. Now, thanks icon has reverse - light background and dark face elements.

Etonkovidova updated the task description. (Show Details)Aug 10 2018, 5:31 PM

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:55 PM

• Phabricator_maintenance edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Readers-Web-Backlog.Sep 13 2018, 6:39 PM

	F22690615: Screen Shot 2018-06-26 at 11.00.02 AM.png
	Jun 26 2018, 6:00 PM

	F22347825: Screen Shot 2018-06-18 at 2.53.53 PM.png
	Jun 26 2018, 5:57 PM

	F22347819: Screen Shot 2018-06-18 at 2.54.28 PM.png
	Jun 26 2018, 5:57 PM

	F22654926: Screen Shot 2018-06-25 at 2.50.40 PM.png
	Jun 25 2018, 11:06 PM

	F24774499: IMG_5765.PNG
	Aug 10 2018, 5:30 PM

	F24774504: IMG_5764.PNG
	Aug 10 2018, 5:30 PM

	F23048597: image.png
	Jun 28 2018, 8:56 AM

	F22869341: undothank.gif
	Jun 27 2018, 11:41 PM

Upgrade Thanks iconClosed, ResolvedPublicActions