Page MenuHomePhabricator

Upgrade Thanks icon
Closed, ResolvedPublic


Thanks uses an outdated PNG for an icon graphic. It also has issues with alignment.
Let's modernise this to an SVG to avoid this problem.

Screen Shot 2018-06-25 at 2.50.40 PM.png (123×141 px, 3 KB)

Acceptance criteria

  • Use mw-ui-icon for generating the icon
  • Update icon to new asset

undothank.gif (610×361 px, 47 KB)

  • Remove CSS code in MobileFrontend that workarounds the lack of usage of mw-ui-icon

QA steps

General QA of the thanks on diff feature - make sure you are happy with the icon and the behaviour.

Event Timeline

@Etonkovidova the fix for T198151 introduced some technical debt which I'm keen to remove (see third acceptance criteria) and having spoken to a few designers it looks like the icon is incorrect.
Newly proposed icon is this (but in white):

Screen Shot 2018-06-26 at 11.00.02 AM.png (117×150 px, 2 KB)

Change 440258 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Thanks@master] Do not use png for thanks button

@alexhollender can you and @Volker_E confirm you are happy with the asset change?

I've been asking on the patch if the icon change is willingly done?
When looking at the location and the use case, your choice, @Jdlrobson, makes sense to me – it's even better than before as the result is signified with the same icon.

image.png (100×690 px, 18 KB)

Only small restriction is that it's a rather complex icon for a button. But as this is a very special, rare use case, I'm for it.

JJMC89 renamed this task from 4aaaaaaaaa to Upgrade Thanks icon.Jul 1 2018, 3:04 AM
JJMC89 lowered the priority of this task from High to Medium.
JJMC89 updated the task description. (Show Details)
JJMC89 added a subscriber: Aklapper.

Change 440258 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Do not use PNG for thanks button

An old patch got merged so adding to the kanbana board to go through our process.
@alexhollender assigning to you for design review.

Checked with iOS and Android - works/looks as expected.

Just as a side note - the previous icon was visually consistent with the user icon: dark background and white face elements. Now, thanks icon has reverse - light background and dark face elements.

IMG_5764.PNG (1×640 px, 114 KB)

IMG_5765.PNG (1×640 px, 98 KB)