Page MenuHomePhabricator
Create Task
Maniphest T198197

Make senses UI call wbladdsense API when saving a new sense
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Introduce SenseChangermediawiki/extensions/WikibaseLexememaster+320 -33
Add support for senses in LexemeRevisionStore.jsmediawiki/extensions/WikibaseLexememaster+95 -6
Use TermMapSerializer in FormSerializer and SenseSerializermediawiki/extensions/WikibaseLexememaster+8 -24
Correctly serialize glosses in SenseSerializermediawiki/extensions/WikibaseLexememaster+13 -1
Turn glosses into a TermMap in frontend, second trymediawiki/extensions/WikibaseLexememaster+60 -47
Turn glosses into a TermMap in frontendmediawiki/extensions/WikibaseLexememaster+58 -66
Introduce SenseSerializer.jsmediawiki/extensions/WikibaseLexememaster+122 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• RazShuty created this task.Jun 26 2018, 11:33 AM
Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Jun 29 2018, 9:26 AM
Addshore edited projects, added Wikidata-Senses-Iteration1; removed Wikidata-Senses-Hike.Jul 3 2018, 11:42 AM
Ladsgroup claimed this task.Jul 3 2018, 12:06 PM
Ladsgroup moved this task from To Do to Doing on the Wikidata-Senses-Iteration1 board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 3 2018, 12:06 PM
gerritbot subscribed.Jul 3 2018, 4:53 PM

Change 443654 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Turn glosses into a TermMap in frontend

https://gerrit.wikimedia.org/r/443654

gerritbot added a project: Patch-For-Review.Jul 3 2018, 4:53 PM
Ladsgroup mentioned this in rEWLE85f90466505e: Turn glosses into a TermMap in frontend.Jul 3 2018, 4:54 PM
gerritbot added a comment.Jul 3 2018, 5:01 PM

Change 443660 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Introduce SenseSerializer.js

https://gerrit.wikimedia.org/r/443660

Ladsgroup mentioned this in rEWLEeac2bec53d3c: Introduce SenseSerializer.js.Jul 3 2018, 5:03 PM
Ladsgroup mentioned this in rEWLE91f6c17648d0: Turn glosses into a TermMap in frontend.Jul 3 2018, 5:32 PM
Ladsgroup mentioned this in rEWLEc5ef15ed1d22: Introduce SenseSerializer.js.
Ladsgroup mentioned this in rEWLE869bf0a9918a: Introduce SenseSerializer.js.Jul 3 2018, 5:38 PM
Ladsgroup mentioned this in rEWLEe41cd9c113cd: Introduce SenseSerializer.js.Jul 3 2018, 6:53 PM
Ladsgroup mentioned this in rEWLEb4ec7c5a7890: Turn glosses into a TermMap in frontend.
Ladsgroup mentioned this in rEWLEb2fd9827a916: Turn glosses into a TermMap in frontend.Jul 3 2018, 7:31 PM
Ladsgroup mentioned this in rEWLE6b84bea217f1: Introduce SenseSerializer.js.
Ladsgroup added a comment.Jul 3 2018, 7:38 PM

Qunit tests pass on my localhost and not here, it's driving me crazy. I'm calling it a day. Feel free to pick this up until the week after next week

Ladsgroup removed Ladsgroup as the assignee of this task.Jul 4 2018, 10:21 AM
Ladsgroup moved this task from Doing to To Do on the Wikidata-Senses-Iteration1 board.
Ladsgroup subscribed.
Addshore mentioned this in rEWLE0b3a6dbad475: Introduce SenseSerializer.js.Jul 12 2018, 9:17 AM
Addshore mentioned this in rEWLEc76d2d31e3a8: Turn glosses into a TermMap in frontend.
Addshore mentioned this in rEWLEa28b27bac168: Turn glosses into a TermMap in frontend.Jul 12 2018, 9:58 AM
Addshore mentioned this in rEWLE6ea48b5bbc05: Introduce SenseSerializer.js.Jul 12 2018, 10:11 AM
gerritbot added a comment.Jul 12 2018, 10:35 AM

Change 443654 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Turn glosses into a TermMap in frontend

https://gerrit.wikimedia.org/r/443654

gerritbot added a comment.Jul 12 2018, 10:48 AM

Change 443660 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Introduce SenseSerializer.js

https://gerrit.wikimedia.org/r/443660

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 12 2018, 11:00 AM
Addshore moved this task from To Do to Doing on the Wikidata-Senses-Iteration1 board.Jul 12 2018, 11:42 AM
gerritbot added a comment.Jul 17 2018, 12:29 PM

Change 446305 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Turn glosses into a TermMap in frontend, second try

https://gerrit.wikimedia.org/r/446305

Ladsgroup mentioned this in rEWLEfdffc548894e: Turn glosses into a TermMap in frontend, second try.Jul 17 2018, 12:33 PM
Ladsgroup mentioned this in rEWLEc53d7100d918: Turn glosses into a TermMap in frontend, second try.Jul 17 2018, 12:43 PM
gerritbot added a comment.Jul 17 2018, 12:56 PM

Change 446305 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Turn glosses into a TermMap in frontend, second try

https://gerrit.wikimedia.org/r/446305

gerritbot added a comment.Jul 17 2018, 1:08 PM

Change 446310 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Correctly serialize glosses in SenseSerializer

https://gerrit.wikimedia.org/r/446310

Lucas_Werkmeister_WMDE mentioned this in rEWLEc12741862d04: Correctly serialize glosses in SenseSerializer.Jul 17 2018, 1:09 PM
gerritbot added a comment.Jul 17 2018, 1:18 PM

Change 446313 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use TermMapSerializer in FormSerializer and SenseSerializer

https://gerrit.wikimedia.org/r/446313

Lucas_Werkmeister_WMDE mentioned this in rEWLEc0f0f125be71: Use TermMapSerializer in FormSerializer and SenseSerializer.Jul 17 2018, 1:19 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE0b30e7a10379: Use TermMapSerializer in FormSerializer and SenseSerializer.Jul 17 2018, 1:24 PM
gerritbot added a comment.Jul 17 2018, 1:39 PM

Change 446310 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Correctly serialize glosses in SenseSerializer

https://gerrit.wikimedia.org/r/446310

gerritbot added a comment.Jul 17 2018, 2:05 PM

Change 446320 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Introduce SenseChanger

https://gerrit.wikimedia.org/r/446320

Ladsgroup mentioned this in rEWLE3b46dc9976c2: Introduce SenseChanger.Jul 17 2018, 2:06 PM
gerritbot added a comment.Jul 17 2018, 2:31 PM

Change 446313 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use TermMapSerializer in FormSerializer and SenseSerializer

https://gerrit.wikimedia.org/r/446313

Ladsgroup mentioned this in rEWLEff4fa0c18a2e: Introduce SenseChanger.Jul 17 2018, 2:45 PM
gerritbot added a comment.Jul 17 2018, 2:56 PM

Change 446332 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Add support for senses in LexemeRevisionStore.js

https://gerrit.wikimedia.org/r/446332

Ladsgroup mentioned this in rEWLEe2a9717b510b: Add support for senses in LexemeRevisionStore.js.Jul 17 2018, 2:57 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration1 board.Jul 17 2018, 3:34 PM
gerritbot added a comment.Jul 17 2018, 3:43 PM

Change 446332 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add support for senses in LexemeRevisionStore.js

https://gerrit.wikimedia.org/r/446332

Lucas_Werkmeister_WMDE mentioned this in rEWLEdedcebba2ae1: Introduce SenseChanger.Jul 17 2018, 4:18 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEf46cd0f221d1: Introduce SenseChanger.Jul 17 2018, 4:43 PM
gerritbot added a comment.Jul 17 2018, 5:35 PM

Change 446320 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Introduce SenseChanger

https://gerrit.wikimedia.org/r/446320

Ladsgroup moved this task from Peer Review to Test (Product Review) on the Wikidata-Senses-Iteration1 board.Jul 17 2018, 5:43 PM
Ladsgroup moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration1 board.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)); removed MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 18 2018, 5:01 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 23 2018, 10:24 AM
Lucas_Werkmeister_WMDE assigned this task to Ladsgroup.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits