Page MenuHomePhabricator

Give Amir access to access to researchers group
Closed, ResolvedPublic

Description

User: amire80
Change: add to researchers group (https://github.com/wikimedia/puppet/blob/279baad47707c02b41a493f8f28894a3d0a64035/modules/admin/data/data.yaml#L120)
Background: Amir needs to run queries on analytics-store.eqiad.wmnet (dbstore1002), for which the normal process is to use the /etc/mysql/conf.d/research-client.cnf. He's already part of statistics-users, which I think should imply being part of researchers for what it's worth. But he needs the access either way.

SRE Clinic Duty Checklist for Access Requests

Most requirements are outlined on https://wikitech.wikimedia.org/wiki/Requesting_shell_access

This checklist should be used on all access requests to ensure that all steps are covered. This includes expansion to access. Please do not check off items on the list below unless you are in Ops and have confirmed the step.

  • - User has signed the L3 Acknowledgement of Wikimedia Server Access Responsibilities Document.
  • - User has a valid NDA on file with WMF legal. (This can be checked by Operations via the NDA tracking sheet & is included in all WMF Staff/Contractor hiring.)
  • - User has provided the following: wikitech username, preferred shell username, email address, and full reasoning for access (including what commands and/or tasks they expect to perform.
  • - User has provided a public SSH key. This ssh key pair should only be used for WMF cluster access, and not share with any other service (this includes not sharing with WMCS access, no shared keys.)
  • - access request (or expansion) has sign off of WMF sponsor/manager (sponser for volunteers, manager for wmf staff)
  • - non-sudo requests: 3 business day wait must pass with no objections being noted on the task - 3 business day wait ends on Friday, June 29th, 2018.
  • - Patchset for access request https://gerrit.wikimedia.org/r/442143

Details

Related Gerrit Patches:
operations/puppet : productionadding amire80 to researchers
operations/puppet : productionadding amire80 to researchers

Event Timeline

Restricted Application added a project: Operations. · View Herald TranscriptJun 26 2018, 1:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
RobH updated the task description. (Show Details)Jun 26 2018, 4:36 PM
RobH assigned this task to Amire80.Jun 26 2018, 4:43 PM
RobH moved this task from Untriaged to Awaiting User Input on the SRE-Access-Requests board.
RobH added subscribers: Nuria, Amire80, RobH.

As part of clinic duty, I've appended in the checklist. In reviewing those steps, I don't see @Amire80's signature on the L3 document.

@Amire80: Please sign the L3, as it is required for shell access. Once done, please assign to @Nuria (if their support isn't already listed on this task by that time) If updates from both @Amire80 and @Nuria are on task, please unassign and clinic duty will pick it back up.

Additionally, increases to your access typically require your managers approval, which I believe is @Nuria? If so, we'll need their approval on this task.

Once both of these are accomplished, there is merely the 3 business day waiting period on this request, as it does not include sudo rights.

RobH triaged this task as Normal priority.Jun 26 2018, 4:44 PM
RobH updated the task description. (Show Details)

Change 442143 had a related patch set uploaded (by RobH; owner: RobH):
[operations/puppet@production] adding amire80 to researchers

https://gerrit.wikimedia.org/r/442143

Change 442144 had a related patch set uploaded (by RobH; owner: RobH):
[operations/puppet@production] adding amire80 to researchers

https://gerrit.wikimedia.org/r/442144

Change 442144 abandoned by RobH:
adding amire80 to researchers

Reason:
accidentally pushed twice somehow

https://gerrit.wikimedia.org/r/442144

RobH updated the task description. (Show Details)Jun 26 2018, 4:52 PM
RobH updated the task description. (Show Details)
Amire80 added a subscriber: Arrbee.Jun 26 2018, 4:55 PM

My manager is @Arrbee. I have shell access and I use other servers, and I have a faint recollection of having a manager approval already, but if it's needed now, I guess @Arrbee can do it.

RobH added a comment.Jun 26 2018, 4:58 PM

My manager is @Arrbee. I have shell access and I use other servers, and I have a faint recollection of having a manager approval already, but if it's needed now, I guess @Arrbee can do it.

Expansions typically still require manager approval. Thanks for signing the L3!

Please also note the 3 day waiting period has started (it isn't awaiting your managers approval, which appears to simply be a matter of course on this.)

RobH reassigned this task from Amire80 to Arrbee.Jun 26 2018, 4:58 PM
RobH updated the task description. (Show Details)

which I think should imply being part of researchers for what it's worth.

Well at that point what exactly distinguishes it from researchers?

Expansions typically still require manager approval. Thanks for signing the L3!

Hello, please consider this request approved. Thanks.

Arrbee removed Arrbee as the assignee of this task.Jun 26 2018, 6:03 PM

As long as no objections are noted, I'll merge this request live on Friday, June 29th, 2018.

herron claimed this task.Jun 29 2018, 6:17 PM

Change 442143 merged by Herron:
[operations/puppet@production] adding amire80 to researchers

https://gerrit.wikimedia.org/r/442143

herron closed this task as Resolved.Jun 29 2018, 6:48 PM

This has been completed

stat1006:~# id amire80
uid=2076(amire80) gid=500(wikidev) groups=500(wikidev),726(statistics-users),714(researchers)

I'll transition to resolved now, but please don't hesitate to re-open if any follow up is needed. Thanks!