Page MenuHomePhabricator
Create Task
Maniphest T198229

[Graph] extension fails QUnit tests due to timeout
Closed, ResolvedPublic
Actions

Description

The Graph extension fails a couple QUnit tests related to visual editor

✖ 2 tests failed

FAILED TESTS:
  ext.graph.visualEditor
    ✖ ve.ce.MWGraphNode.static
      HeadlessChrome 0.0.0 (Linux 0.0.0)  // that is chrome 66
    Test took longer than 60000ms; test timed out.
        at node_modules/qunit/qunit/qunit.js:2053:7
    

    ✖ ve.ui.TableWidget
      HeadlessChrome 0.0.0 (Linux 0.0.0)

Repro: comment check experimental on dummy change https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Graph/+/430655/

I reproduce it locally with Chrome v66 and Firefox 52

See also jQuery 3.0.0 deferred updates no more passing the context prevneting one from looking at this.state() https://github.com/jquery/jquery/issues/3060

Details

ProjectBranchLines +/-Subject
integration/configmaster+1 -2Migrate Graph to Quibble
mediawiki/extensions/Graphmaster+6 -6jQuery deferred callback no more have a context
mediawiki/extensions/Graphmaster+5 -1VE table widget is still a work in progress
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Jun 26 2018, 4:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2018, 4:22 PM
hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 26 2018, 4:25 PM
hashar added a parent task: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
hashar updated the task description. (Show Details)Jun 26 2018, 4:27 PM
hashar added a comment.Jun 26 2018, 4:44 PM

I looked at ve.ui.TableWidget failure previously T151262#4253730 The test should be skipped/marked pending.

The timeout one, I havent investigated.

gerritbot added a subscriber: gerritbot.Jun 26 2018, 4:54 PM

Change 442145 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Graph@master] VE table widget is still a work in progress

https://gerrit.wikimedia.org/r/442145

gerritbot added a project: Patch-For-Review.Jun 26 2018, 4:54 PM
Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.Jun 26 2018, 6:52 PM
gerritbot added a comment.Jun 26 2018, 8:55 PM

Change 442145 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] VE table widget is still a work in progress

https://gerrit.wikimedia.org/r/442145

hashar claimed this task.Jun 27 2018, 9:47 AM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 27 2018, 9:47 AM
gerritbot added a comment.Jun 27 2018, 9:47 AM

Change 442259 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Graph@master] jQuery deferred callback no more have a context

https://gerrit.wikimedia.org/r/442259

hashar updated the task description. (Show Details)Jun 27 2018, 9:51 AM
hashar moved this task from Backlog to Prioritized on the MediaWiki-extensions-Graph board.Jun 27 2018, 10:27 AM
hashar mentioned this in T151262: Number of columns for X and Y values for a graph keep increasing every time I open the dialog for empty <graph> node.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 5:02 PM
gerritbot added a comment.Jul 4 2018, 8:33 PM

Change 442259 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] jQuery deferred callback no more have a context

https://gerrit.wikimedia.org/r/442259

gerritbot added a comment.Jul 5 2018, 8:06 AM

Change 443908 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate Graph to Quibble

https://gerrit.wikimedia.org/r/443908

gerritbot added a comment.Jul 5 2018, 8:08 AM

Change 443908 merged by jenkins-bot:
[integration/config@master] Migrate Graph to Quibble

https://gerrit.wikimedia.org/r/443908

hashar closed this task as Resolved.Jul 5 2018, 8:09 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 5 2018, 8:09 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL