Maniphest T198229

[Graph] extension fails QUnit tests due to timeout
Closed, ResolvedPublic
Actions

Description

The Graph extension fails a couple QUnit tests related to visual editor

✖ 2 tests failed

FAILED TESTS:
  ext.graph.visualEditor
    ✖ ve.ce.MWGraphNode.static
      HeadlessChrome 0.0.0 (Linux 0.0.0)  // that is chrome 66
    Test took longer than 60000ms; test timed out.
        at node_modules/qunit/qunit/qunit.js:2053:7
    

    ✖ ve.ui.TableWidget
      HeadlessChrome 0.0.0 (Linux 0.0.0)

Repro: comment check experimental on dummy change https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Graph/+/430655/

I reproduce it locally with Chrome v66 and Firefox 52

See also jQuery 3.0.0 deferred updates no more passing the context prevneting one from looking at this.state() https://github.com/jquery/jquery/issues/3060

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/Graph	REL1_31	+6 -6	jQuery deferred callback no more have a context
mediawiki/extensions/Graph	REL1_31	+5 -1	VE table widget is still a work in progress
integration/config	master	+1 -2	Migrate Graph to Quibble
mediawiki/extensions/Graph	master	+6 -6	jQuery deferred callback no more have a context
mediawiki/extensions/Graph	master	+5 -1	VE table widget is still a work in progress

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T190097 Migrate all CI jobs from Nodepool, deprecate its use
Resolved	hashar	T183512 [EPIC] Migrate Mediawiki jobs from Nodepool to Docker
Resolved	hashar	T198229 [Graph] extension fails QUnit tests due to timeout

Event Timeline

hashar created this task.Jun 26 2018, 4:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2018, 4:22 PM

hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 26 2018, 4:25 PM

hashar added a parent task: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.

hashar updated the task description. (Show Details)Jun 26 2018, 4:27 PM

I looked at ve.ui.TableWidget failure previously T151262#4253730 The test should be skipped/marked pending.

The timeout one, I havent investigated.

Change 442145 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Graph@master] VE table widget is still a work in progress

https://gerrit.wikimedia.org/r/442145

gerritbot added a project: Patch-For-Review.Jun 26 2018, 4:54 PM

Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.Jun 26 2018, 6:52 PM

Change 442145 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] VE table widget is still a work in progress

https://gerrit.wikimedia.org/r/442145

hashar claimed this task.Jun 27 2018, 9:47 AM

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 27 2018, 9:47 AM

Change 442259 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Graph@master] jQuery deferred callback no more have a context

https://gerrit.wikimedia.org/r/442259

hashar updated the task description. (Show Details)Jun 27 2018, 9:51 AM

hashar moved this task from Backlog to Prioritized on the MediaWiki-extensions-Graph board.Jun 27 2018, 10:27 AM

hashar mentioned this in T151262: Number of columns for X and Y values for a graph keep increasing every time I open the dialog for empty <graph> node.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 5:02 PM

Change 442259 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] jQuery deferred callback no more have a context

https://gerrit.wikimedia.org/r/442259

Change 443908 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate Graph to Quibble

https://gerrit.wikimedia.org/r/443908

Change 443908 merged by jenkins-bot:
[integration/config@master] Migrate Graph to Quibble

https://gerrit.wikimedia.org/r/443908

hashar closed this task as Resolved.Jul 5 2018, 8:09 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 5 2018, 8:09 AM

Change 653993 had a related patch set uploaded (by Umherirrender; owner: Hashar):
[mediawiki/extensions/Graph@REL1_31] jQuery deferred callback no more have a context

https://gerrit.wikimedia.org/r/653993

Change 653994 had a related patch set uploaded (by Umherirrender; owner: Hashar):
[mediawiki/extensions/Graph@REL1_31] VE table widget is still a work in progress

https://gerrit.wikimedia.org/r/653994

Change 653994 merged by Umherirrender:
[mediawiki/extensions/Graph@REL1_31] VE table widget is still a work in progress

https://gerrit.wikimedia.org/r/653994

Change 653993 merged by Umherirrender:
[mediawiki/extensions/Graph@REL1_31] jQuery deferred callback no more have a context

https://gerrit.wikimedia.org/r/653993

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2021, 7:10 PM