Page MenuHomePhabricator

VE Wikitext editor cursor is misplaced on Minerva desktop when syntax highlighting enabled
Closed, ResolvedPublic

Assigned To
None
Authored By
Jdlrobson
Jun 26 2018, 11:39 PM
Referenced Files
Restricted File
Jun 15 2022, 9:54 PM
Restricted File
Jun 15 2022, 9:54 PM
F22719406: Screen Shot 2018-06-27 at 09.47.45.png
Jun 27 2018, 7:50 AM
F22698761: vesourcemisplacement.gif
Jun 26 2018, 11:39 PM

Description

The cursor always appears below the line I am typing on which is a little jarring.

vesourcemisplacement.gif (614×957 px, 114 KB)

Is there a skinStyle can we can add to rectify this or is this a problem in the JavaScript?

Event Timeline

Jdlrobson renamed this task from VE Wikitext editor cursor is misplaced to VE Wikitext editor cursor is misplaced on Minerva desktop.Jun 26 2018, 11:39 PM

The surfaces ve-ce-documentNode and CodeMirror don't overlap. I could fix the problem by setting a 1.5em padding on CodeMirror, to match what the document node has in padding. We need to check how the settings are adapted for things like monobook.

Screen Shot 2018-06-27 at 09.47.45.png (254×1 px, 114 KB)

Esanders renamed this task from VE Wikitext editor cursor is misplaced on Minerva desktop to VE Wikitext editor cursor is misplaced on Minerva desktop when syntax highlighting enabled.Sep 10 2018, 2:25 PM
matmarex subscribed.

I don't know what resolved it, but it seems to work correctly for me now (testing at https://en.wikipedia.org/wiki/The_Fighting_Temeraire?useskin=minerva&action=edit).

{F35245007}{F35245011}

I remember that a few similar bugs have been fixed over the years, so I guess one of them must have been the same issue as this. Or maybe some Minerva change accidentally fixed it.