Page MenuHomePhabricator
Create Task
Maniphest T198279

Exception "Key contains invalid characters" from MemcachedBagOStuff.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Seen at https://logstash-beta.wmflabs.org

[{exception_id}] {exception_url} Exception from line 156 of /srv/mediawiki/php-master/includes/libs/objectcache/MemcachedBagOStuff.php: Key contains invalid characters: WANCache:v:enwiki:filerepo:wikimediacommons:RemoteFileDescription:url:en:Dülmen,_Al

Seems like this might have something to do with the mcrouter/nutrcracker reconfiguration, with regards to makeKey encoding. But not sure, could be an unrelated pre-existing issue?

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
objectcache: define makeKey()/makeGlobalKey() for ReplicatedBagOStuffKrinklemediawiki/corewmf/1.32.0-wmf.10+8 -0
filerepo: clean up remote description cache keysAaron Schulzmediawiki/coremaster+3 -5
objectcache: define makeKey()/makeGlobalKey() for ReplicatedBagOStuffAaron Schulzmediawiki/coremaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Jun 27 2018, 12:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2018, 12:51 AM
Krinkle mentioned this in T198280: Beta Cluster: Unable to obtain lock via objectcache (memcached add() fails).Jun 27 2018, 1:25 AM
gerritbot subscribed.Jun 27 2018, 7:26 AM

Change 442239 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] filerepo: clean up remote description cache keys

https://gerrit.wikimedia.org/r/442239

gerritbot added a project: Patch-For-Review.Jun 27 2018, 7:26 AM
gerritbot added a comment.Jun 27 2018, 2:16 PM

Change 442245 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] objectcache: define makeKey()/makeGlobalKey() for ReplicatedBagOStuff

https://gerrit.wikimedia.org/r/442245

gerritbot added a comment.Jun 27 2018, 3:28 PM

Change 442326 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@wmf/1.32.0-wmf.10] objectcache: define makeKey()/makeGlobalKey() for ReplicatedBagOStuff

https://gerrit.wikimedia.org/r/442326

gerritbot added a comment.Jun 27 2018, 3:55 PM

Change 442245 merged by jenkins-bot:
[mediawiki/core@master] objectcache: define makeKey()/makeGlobalKey() for ReplicatedBagOStuff

https://gerrit.wikimedia.org/r/442245

gerritbot added a comment.Jun 27 2018, 10:16 PM

Change 442239 merged by jenkins-bot:
[mediawiki/core@master] filerepo: clean up remote description cache keys

https://gerrit.wikimedia.org/r/442239

Krinkle closed this task as Resolved.Jun 28 2018, 9:33 PM
Krinkle assigned this task to aaron.
Krinkle triaged this task as High priority.
Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.
Krinkle removed a project: Patch-For-Review.

Error rate dropped to 0 for MemcachedBagOStuff in logstash-beta. Yay!

Screen Shot 2018-06-28 at 22.32.22.png (2,516×508 px, 94 KB)

Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jun 28 2018, 9:33 PM
Krinkle added a parent task: T192370: Deploy mcrouter to production as a wancache backend.
Krinkle edited parent tasks, added: T198239: Rollout use of mcrouter for MediaWiki in production; removed: T192370: Deploy mcrouter to production as a wancache backend.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 6:01 PM
gerritbot added a comment.Jul 3 2018, 9:32 PM

Change 442326 abandoned by Krinkle:
objectcache: define makeKey()/makeGlobalKey() for ReplicatedBagOStuff

https://gerrit.wikimedia.org/r/442326

gerritbot added a comment.Jul 10 2018, 12:30 PM

Change 442326 restored by Aaron Schulz:
objectcache: define makeKey()/makeGlobalKey() for ReplicatedBagOStuff

https://gerrit.wikimedia.org/r/442326

gerritbot added a comment.Jul 10 2018, 12:48 PM

Change 442326 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.10] objectcache: define makeKey()/makeGlobalKey() for ReplicatedBagOStuff

https://gerrit.wikimedia.org/r/442326

ReleaseTaggerBot edited projects, added: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 11 2018, 12:01 AM
Krinkle mentioned this in T199237: Unable to submit edit due to Exception "Key contains invalid characters" from MemcachedBagOStuff.Jul 11 2018, 3:44 AM
Krinkle mentioned this in T198239: Rollout use of mcrouter for MediaWiki in production.Jul 12 2018, 3:08 AM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits