Page MenuHomePhabricator
Create Task
Maniphest T198324

Set a tag so that files imported with FileImporter can be filtered in Recent Changes
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
thiemowmde
Authored By
Bmueller
Jun 27 2018, 12:45 PM
Tags
Referenced Files
F27637533: Screenshot from 2018-12-19 15-44-56.png
Dec 19 2018, 2:51 PM
F27637532: Screenshot from 2018-12-19 15-36-42.png
Dec 19 2018, 2:51 PM
F27637530: Screenshot from 2018-12-19 15-45-12.png
Dec 19 2018, 2:51 PM
F27637531: Screenshot from 2018-12-19 15-35-56.png
Dec 19 2018, 2:51 PM
Subscribers
Aklapper
Bmueller
gerritbot
JStrodt_WMDE
Lea_WMDE
Pikne
WMDE-Fisch

Description

Acceptance Criteria

  • Set a tag so that files imported with FileImporter can be filtered in Recent Changes
  • Use the wording as described below

Wording
Labels according to https://en.wikipedia.org/wiki/Special:Tags:
Tag name: fileimporter
Appearance on change lists: imported with FileImporter
Description: File imported from another wiki, including file and page history.

Previous discussions
See https://commons.wikimedia.org/w/index.php?title=Commons:Village_pump&oldid=308275483, Section June 25, move files from a local wiki to Commons

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/FileImportermaster+3 -2Add test for the upload log tag
mediawiki/extensions/FileImportermaster+20 -18Test to check for correctly added tags
mediawiki/extensions/FileImportermaster+69 -2Add "fileimporter" tag to new import log entry and null revision
Customize query in gerrit

Related Objects

Event Timeline

Bmueller created this task.Jun 27 2018, 12:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2018, 12:45 PM
Bmueller added projects: TCB-Team (now WMDE-TechWish), Move-Files-To-Commons.Jun 27 2018, 12:45 PM
Lea_WMDE set the point value for this task to 3.Nov 28 2018, 4:57 PM
Lea_WMDE added a subscriber: Lea_WMDE.

We should tag all logs associated with the import null revision.

Pikne added a subscriber: Pikne.EditedNov 29 2018, 7:22 AM

If there's already going to be an import log entry then isn't the change tag kind of redundant?

Edit: I see, it may not be redundant depending on if import log enhancement comes with type of import that woud allow filtering file imports or not.

Pikne mentioned this in T209942: FileImporter should add entries to the import log.Dec 4 2018, 7:29 AM
Lea_WMDE moved this task from Backlog to Tickets in preparation/investigation on the Move-Files-To-Commons board.Dec 4 2018, 10:56 AM
Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-12-04.Dec 4 2018, 1:33 PM

Concrete label to come as fast as possible

Lea_WMDE moved this task from Tickets in preparation/investigation to Tickets in sprint on the Move-Files-To-Commons board.Dec 4 2018, 4:01 PM
JStrodt_WMDE added a subscriber: JStrodt_WMDE.Dec 5 2018, 2:21 PM
In T198324#4797448, @Lea_WMDE wrote:

Concrete label to come as fast as possible

Labels according to https://en.wikipedia.org/wiki/Special:Tags:

Tag name: fileimporter
Appearance on change lists: imported with FileImporter
Description: File imported from another wiki, including file and page history.

Lea_WMDE triaged this task as Medium priority.Dec 6 2018, 10:13 AM
Lea_WMDE updated the task description. (Show Details)
gerritbot added a subscriber: gerritbot.Dec 17 2018, 3:36 PM

Change 480093 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] [WIP] Add "fileimporter" tag

https://gerrit.wikimedia.org/r/480093

gerritbot added a project: Patch-For-Review.Dec 17 2018, 3:36 PM
thiemowmde claimed this task.Dec 17 2018, 3:36 PM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-12-04 board.
thiemowmde mentioned this in rEFLI05719b4ed366: [WIP] Add "fileimporter" tag.Dec 17 2018, 3:39 PM
Lea_WMDE added a project: WMDE-QWERTY-X-Mas-Sprint-2018-12-18.Dec 18 2018, 1:12 PM
Lea_WMDE moved this task from Backlog to Prioritized on the WMDE-QWERTY-X-Mas-Sprint-2018-12-18 board.
thiemowmde mentioned this in rEFLIe72826cdac76: Add "fileimporter" tag to new import log entry and null revision.Dec 19 2018, 1:37 PM
thiemowmde mentioned this in rEFLIe1176a197588: Add "fileimporter" tag to new import log entry and null revision.Dec 19 2018, 2:23 PM
thiemowmde moved this task from Prioritized to Review on the WMDE-QWERTY-X-Mas-Sprint-2018-12-18 board.Dec 19 2018, 2:51 PM

I kind of gave up trying to write a nice automated test for this for various reasons. Instead, I did a manual test and confirmed the tag appears in all relevant situations:

Screenshot from 2018-12-19 15-45-12.png (454×798 px, 71 KB)

Screenshot from 2018-12-19 15-35-56.png (372×799 px, 69 KB)

Screenshot from 2018-12-19 15-36-42.png (442×800 px, 67 KB)

Screenshot from 2018-12-19 15-44-56.png (480×796 px, 69 KB)

Technically the tag is linked to the revision ID (for the page history and Special:Contributions), the log entry ID (for Special:Log), and a recent changes ID (relevant for – obviously – recent changes).

gerritbot added a comment.Dec 19 2018, 4:44 PM

Change 480792 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Test to check for correctly added tags

https://gerrit.wikimedia.org/r/480792

WMDE-Fisch mentioned this in rEFLI96d1342dc5c5: Test to check for correctly added tags.Dec 19 2018, 4:45 PM
WMDE-Fisch mentioned this in rEFLI5edb110258fb: Add "fileimporter" tag to new import log entry and null revision.Dec 19 2018, 5:05 PM
WMDE-Fisch mentioned this in rEFLI8b31e935d9a7: Test to check for correctly added tags.
WMDE-Fisch mentioned this in rEFLI37c4b845b170: Test to check for correctly added tags.Dec 19 2018, 5:13 PM
gerritbot added a comment.Dec 19 2018, 5:18 PM

Change 480093 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add "fileimporter" tag to new import log entry and null revision

https://gerrit.wikimedia.org/r/480093

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Dec 19 2018, 6:01 PM
thiemowmde mentioned this in rEFLId3dca3aca27e: Test to check for correctly added tags.Dec 20 2018, 9:43 AM
WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-X-Mas-Sprint-2018-12-18 board.Dec 20 2018, 10:12 AM
WMDE-Fisch mentioned this in rEFLIabde2d4e375f: Test to check for correctly added tags.Dec 21 2018, 1:08 PM
thiemowmde mentioned this in rEFLI7f8be1e5c06e: Test to check for correctly added tags.Dec 26 2018, 6:46 PM
gerritbot added a comment.Jan 3 2019, 8:00 AM

Change 480792 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Test to check for correctly added tags

https://gerrit.wikimedia.org/r/480792

WMDE-Fisch added a subscriber: WMDE-Fisch.Jan 7 2019, 12:41 PM

Can be tested on beta e.g. here:
https://commons.wikimedia.beta.wmflabs.org/wiki/Special:RecentChanges?tagfilter=fileimporter&limit=50&days=7&enhanced=1&urlversion=2

gerritbot added a comment.Jan 9 2019, 1:13 PM

Change 483119 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Add test for the upload log tag

https://gerrit.wikimedia.org/r/483119

WMDE-Fisch mentioned this in rEFLI45b3a7da1eaa: Add test for the upload log tag.Jan 9 2019, 1:14 PM
WMDE-Fisch added a comment.Jan 10 2019, 10:16 AM

Please note, that we just discovered an issue in core that blocks the creation for the upload log tag, there's a follow up task for that T213280

jijiki mentioned this in rEFLI84e29455faff: Add test for the upload log tag.Mar 18 2019, 4:37 PM
WMDE-Fisch added a comment.Mar 26 2019, 2:00 PM

Currently some tags on the log entries can't be created due to T213280: Tags for different log entries on the same revision not working - https://gerrit.wikimedia.org/r/483119 includes a test that can validate if the entries are all created.

WMDE-Fisch closed this task as Resolved.Mar 26 2019, 2:08 PM

Let's close this for now since it's unclear if T213280 can be resolved soonish and everything else is tracked in there.

gerritbot added a comment.Sep 7 2021, 1:39 PM

Change 483119 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/FileImporter@master] Add test for the upload log tag

Reason:

The TODO is still in the codebase. But the code changed a lot since then. This patch can't be applied anymore.

https://gerrit.wikimedia.org/r/483119

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2021, 2:11 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL