Page MenuHomePhabricator

[wmf.10 - regression] Preferences-Beta features page displayed centered
Closed, ResolvedPublic

Description

Screen Shot 2018-06-27 at 9.30.31 AM.png (719×1 px, 212 KB)

vs. wmf.8:

Screen Shot 2018-06-27 at 9.54.55 AM.png (730×1 px, 178 KB)

Event Timeline

matmarex added subscribers: Fomafix, matmarex.

They are not quite centered, rather there is a 20% margin on the left side:

image.png (981×1 px, 217 KB)

These elements have display: none in wmf.8, because the element <table id="mw-htmlform-betafeatures"> also has class="mw-htmlform-nolabel".

I would guess that this is caused by the HTMLForm changes in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/329639.

Turns out I was wrong, @Ryasmeen, this isn't just testwiki-being-testwiki. :-(

Change 442736 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] Allow overloading of getLabel() with return '&#160;'

https://gerrit.wikimedia.org/r/442736

Change 442736 merged by Fomafix:
[mediawiki/core@master] Allow overloading of getLabel() with return '&#160;'

https://gerrit.wikimedia.org/r/442736

Change 442832 had a related patch set uploaded (by Bartosz Dziewoński; owner: Fomafix):
[mediawiki/core@wmf/1.32.0-wmf.10] Allow overloading of getLabel() with return '&#160;'

https://gerrit.wikimedia.org/r/442832

Change 442832 merged by DCausse:
[mediawiki/core@wmf/1.32.0-wmf.10] Allow overloading of getLabel() with return '&#160;'

https://gerrit.wikimedia.org/r/442832