Page MenuHomePhabricator
Create Task
Maniphest T198364

PageTriage with AfC option: Options removed from NPP option are incorrectly saved when switching to AfC
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Reproduce:

  1. Make sure Special:NewPagesFeed has AfC enabled
  2. In NPP mode, open the filters popup, remove all checkboxes; note: The 'Set filters' button is disabled
  3. Without clicking anything else or applying anything, click the "AfC" option to switch to AfC mode
  4. Switch back to NPP mode

Expected: The invalid options (the state where 'set filters' button was disabled) should have been ignored, and we should have the filters that were there before, or default filters.

Actual result: The filters are now on empty state, which is invalid, and NPP shows no articles at all.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Sanity-check NPP API filter values and add defaultmediawiki/extensions/PageTriagemaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Mooeypoo created this task.Jun 27 2018, 11:28 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 27 2018, 11:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mooeypoo added a parent task: T195545: New Pages Feed: add drafts to the feed (1.1).Jun 28 2018, 3:49 PM
gerritbot subscribed.Jun 28 2018, 8:49 PM

Change 442980 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/PageTriage@master] Sanity-check NPP API filter values and add default

https://gerrit.wikimedia.org/r/442980

gerritbot added a project: Patch-For-Review.Jun 28 2018, 8:49 PM
Mooeypoo claimed this task.Jun 28 2018, 8:50 PM

This probably isn't the best solution ever, sicne it will override previous values -- but it only happens if the user unclicked both checkboxes anyways, and it will only potentially override the specific unreviewed/reviewed checkbox state, so I think that's acceptable for a quickfix.

Mooeypoo moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.Jun 28 2018, 8:51 PM
kaldari set the point value for this task to 3.Jul 3 2018, 11:24 PM
gerritbot added a comment.Jul 4 2018, 12:54 AM

Change 442980 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Sanity-check NPP API filter values and add default

https://gerrit.wikimedia.org/r/442980

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 4 2018, 1:00 AM
Samwilson subscribed.Jul 9 2018, 3:26 AM

Is there anything left to do for this?

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 9 2018, 3:26 AM
JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 10 2018, 5:29 PM
Mooeypoo added a subscriber: MMiller_WMF.Jul 10 2018, 11:31 PM

@MMiller_WMF this is ready to test; let me know if my reproduction explanation is lacking -- the title language is a little confusing.

Niharika moved this task from Needs Review/Feedback to QA on the Community-Tech-Sprint board.Jul 11 2018, 12:02 AM
SBisson moved this task from Needs Discussion to External on the Growth-Team board.Jul 20 2018, 6:16 PM
Niharika added a project: English-Wikipedia-New-Pages-Patrol.Jul 27 2018, 12:51 AM
Niharika added a project: Community-Tech.Jul 27 2018, 9:08 PM
Niharika moved this task from New & TBD Tickets to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Jul 27 2018, 9:12 PM
Etonkovidova closed this task as Resolved.Jul 30 2018, 8:09 PM
Etonkovidova subscribed.

Checked in betalabs and testwiki (wmf.14) - the issue is fixed. If all checkboxes are un-checked with NPP option and then a user switches to AfC and back to NPP - the filters will revert to the last selected filters or to defaul.

MusikAnimal moved this task from QA to Q1 2018-19 on the Community-Tech-Sprint board.Jul 30 2018, 8:17 PM
MusikAnimal subscribed.

Thanks!

DannyS712 moved this task from Backlog to PageCuration & NewPagesFeed on the English-Wikipedia-New-Pages-Patrol board.Dec 2 2019, 9:12 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 2 2019, 10:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits