Page MenuHomePhabricator
Create Task
Maniphest T198471

CX2: Opening link inspector scrolls page up
Closed, ResolvedPublic
Actions

Description

Opening link inspector inside complex dialog scrolls the page to the top. Closing the dialog restores the context.

cx2-link-inspector-jump.gif (942×1 px, 3 MB)

I'm pretty sure this scrolling happens in regular target page surface, but not sure about the steps to reproduce.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ContentTranslationmaster+10 -0Fix page jump when link inspector is opened
Customize query in gerrit

Related Objects

Event Timeline

• Petar.petkovic created this task.Jun 29 2018, 11:58 AM
Arrbee moved this task from Needs Triage to Bugs on the ContentTranslation board.Jul 3 2018, 3:17 PM
• Petar.petkovic merged a task: T201570: CX2: Click on 'Edit' for links - page jumps to the top .Aug 9 2018, 7:42 AM
• Petar.petkovic added a subscriber: Etonkovidova.
Pginer-WMF added a project: Language-2018-July-September.Aug 24 2018, 3:20 PM
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 24 2018, 3:20 PM
Pginer-WMF mentioned this in T191007: CX2: Preview existing pages for the selected text.Aug 30 2018, 10:03 AM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-July-September board.Sep 5 2018, 9:05 AM
KartikMistry added a subscriber: KartikMistry.Sep 24 2018, 7:01 AM
Pginer-WMF edited projects, added Language-2018-Oct-December; removed Language-2018-July-September.Oct 1 2018, 9:30 AM
Arrbee edited projects, added Language-Team (Language-2018-October-December); removed Language-2018-Oct-December.Oct 4 2018, 4:52 PM
• Petar.petkovic mentioned this in T206978: The input method dropdown scrolls to the top when clicking on a section in CX for the second time.Oct 15 2018, 1:12 PM
Pginer-WMF added a comment.Nov 16 2018, 12:10 PM

In recent research sessions (T207831) we've observed the scroll jump happening for links but also with the add citation panel.

Pginer-WMF renamed this task from Opening link inspector scrolls page up to CX2: Opening link inspector scrolls page up.Nov 16 2018, 12:11 PM
Amire80 mentioned this in T209270: CX2: Invite Hebrew Wikipedia to try version 2.Nov 19 2018, 5:30 PM
Amire80 added a subscriber: Amire80.Nov 20 2018, 8:19 AM

Possibly related to a VE bug: T180242: VisualEditor: tall popup windows sometimes scroll target out of view.

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2018-October-December) board.Nov 20 2018, 8:20 AM
• Petar.petkovic claimed this task.Dec 18 2018, 1:23 AM
• Petar.petkovic moved this task from Priority backlog to In Progress on the Language-Team (Language-2018-October-December) board.
gerritbot added a subscriber: gerritbot.Dec 19 2018, 8:39 PM

Change 480823 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix page jump when link inspector is opened

https://gerrit.wikimedia.org/r/480823

gerritbot added a project: Patch-For-Review.Dec 19 2018, 8:39 PM
• Petar.petkovic moved this task from In Progress to In Review on the Language-Team (Language-2018-October-December) board.Dec 19 2018, 8:39 PM
Pginer-WMF edited projects, added Language-Team (Language-2019-January-March); removed Language-Team (Language-2018-October-December).Dec 27 2018, 8:39 AM
Pginer-WMF moved this task from Backlog to In Review on the Language-Team (Language-2019-January-March) board.
gerritbot added a comment.Jan 8 2019, 8:06 PM

Change 480823 merged by Petar.petkovic:
[mediawiki/extensions/ContentTranslation@master] Fix page jump when link inspector is opened

https://gerrit.wikimedia.org/r/480823

• Petar.petkovic removed a project: Patch-For-Review.Jan 8 2019, 8:06 PM
• Petar.petkovic moved this task from In Review to Needs QA-before deployment on the Language-Team (Language-2019-January-March) board.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 8 2019, 9:00 PM
Etonkovidova closed this task as Resolved.Jan 18 2019, 2:53 AM
Etonkovidova moved this task from Needs QA-before deployment to Done on the Language-Team (Language-2019-January-March) board.

Checked in wmf.13 -the page stays in place after opening/closing the link inspector.

link_inspector_correct.gif (687×1 px, 1 MB)

• Petar.petkovic removed a subscriber: gerritbot.Jan 18 2019, 2:59 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL