Page MenuHomePhabricator

Drop rev_text_id and ar_text_id when running update.php
Open, NormalPublic

Description

The rev_text_id and ar_text_id are no longer populated once compatibility code has been removed as per T198557. Thus, update.php should drop them.

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

daniel created this task.Jun 29 2018, 3:34 PM
daniel triaged this task as Normal priority.
Tgr added a comment.Jun 29 2018, 6:06 PM

That would mean MediaWiki could never not set SCHEMA_COMPAT_WRITE_OLD by default (or risk catastrophic data loss on upgrade), no?

Well, SCHEMA_COMPAT_WRITE_OLD is effectively the default now.

Dropping these fields basically means only SCHEMA_COMPAT_WRITE_NEW | SCHEMA_COMPAT_READ_NEW is supported. So it can only be done after migration is complete.

I was planning to create a few more tickets to track the steps towards that point. Will do that later, running out of battery...

Tgr added a comment.Jun 29 2018, 8:20 PM

It's just a bit scary when that's triggered by update.php - if something goes wrong with the migration script you could lose all content.
When HitCounter was removed from core the update just deleted all stored data, which understandably made people very unhappy. We should not do something like that again, even by accident.

daniel updated the task description. (Show Details)
daniel removed subscribers: aude, Addshore, gerritbot.