Page MenuHomePhabricator

php-lint in wikibase times out
Open, Needs TriagePublic

Description

parallel-lint is timing out and failing: https://gerrit.wikimedia.org/r/442209

@hashar thinks this is because:

[Wikibase has] a lot of php files. parallel-lint with HHVM is slow hence the 350 seconds timeout being reached. Can you fill it as another task please? It is probably missing a COMPOSER_PROCESS_TIMEOUT=600 and ideally we should only lint files that got changed by the patch (which we do for mediawiki/core).

Event Timeline

cscott created this task.Jun 29 2018, 3:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2018, 3:42 PM

That is still going on. For extensions and skins Quibble does:

composer validate --no-check-publish
composer install --no-progress --prefer-dist --profile -v
composer test

Wikibase composer.json has:

{
  "scripts": {
    "test": [
      "composer validate --no-interaction",
      "parallel-lint . --exclude vendor --exclude node_modules --exclude .git",
      "phpcs -p -s",
      "minus-x check ."
}

Hence it runs parallel-lint on every single files which takes roughly 5 minutes by itself.

mediawiki/core has a similar issue, but Quibble passes the list of files changed in the patchset to the composer test command. This way it only lint altered files which is way faster.