Maniphest T198510

[Wikistats2] Negative numbers in chart axis are not abbreviated
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	mforns
	Jun 29 2018, 7:15 PM

Description

https://stats.wikimedia.org/v2/#/ja.wikipedia.org/content/net-bytes-difference/normal|line|3-Month~2018030300~2018062900|editor_type~anonymous*group-bot*name-bot*user

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Corrected negative number abbreviation in chart axis	analytics/wikistats2	master	+5 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		sahil505	T189210 [Analytics] Improvements to Wikistats2 front-end
		Resolved		sahil505	T198510 [Wikistats2] Negative numbers in chart axis are not abbreviated

Event Timeline

mforns created this task.Jun 29 2018, 7:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2018, 7:15 PM

• fdans moved this task from Incoming to Mentoring on the Analytics board.Jul 2 2018, 3:49 PM

sahil505 claimed this task.Jul 4 2018, 1:01 PM

sahil505 triaged this task as High priority.

sahil505 added a project: Analytics-Kanban.

sahil505 set the point value for this task to 3.

sahil505 moved this task from Next Up to In Progress on the Analytics-Kanban board.Jul 5 2018, 9:57 AM

Interesting! This has been reported as an issue with numeral.

https://github.com/adamwdraper/Numeral-js/issues/222

Change 444012 had a related patch set uploaded (by Sahil505; owner: Sahil505):
[analytics/wikistats2@master] Corrected negative number abbreviation in chart axis

https://gerrit.wikimedia.org/r/444012

gerritbot added a project: Patch-For-Review.Jul 5 2018, 4:04 PM

sahil505 moved this task from In Progress to In Code Review on the Analytics-Kanban board.Jul 5 2018, 4:04 PM

sahil505 added a project: Data-Engineering-Wikistats.Jul 5 2018, 4:28 PM

sahil505 mentioned this in T189964: GSoC Proposal 2018 : [Analytics] Improvements to Wikistats2 front-end.Jul 7 2018, 6:33 AM

sahil505 added a parent task: T189210: [Analytics] Improvements to Wikistats2 front-end .

Change 444012 merged by Mforns:
[analytics/wikistats2@master] Corrected negative number abbreviation in chart axis

https://gerrit.wikimedia.org/r/444012

• Nuria moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Jul 13 2018, 4:07 PM

• Nuria moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Jul 17 2018, 4:55 PM

• Nuria closed this task as Resolved.Aug 22 2018, 10:45 PM