Page MenuHomePhabricator

List differ gets confused by multiple lines being removed
Closed, ResolvedPublic

Description

https://en.wikipedia.org/w/index.php?title=Pygmy_goat&type=revision&diff=848198517&oldid=848198396&diffmode=visual

image.png (2×3 px, 321 KB)

Here the removal is shown in the wrong place, probably because of the empty list items that were removed.

Edit: The failing case is much simpler, and a regression. Just removing any two items from the middle of a list will render them in the wrong order:

image.png (133×99 px, 2 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Esanders renamed this task from List differ gets confused by empty lines being removed to List differ gets confused by multiple lines being removed.Jan 21 2022, 12:28 AM
Esanders added a project: Regression.
Esanders updated the task description. (Show Details)

Technically a regression, but this has been this way since we added custom list diffing: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/428259

Change 755839 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Fix list diffs

https://gerrit.wikimedia.org/r/755839

Change 755839 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Fix list diffs

https://gerrit.wikimedia.org/r/755839

Change 757094 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7c6e1b91f)

https://gerrit.wikimedia.org/r/757094

Change 757094 merged by Bartosz Dziewoński:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7c6e1b91f)

https://gerrit.wikimedia.org/r/757094

ppelberg claimed this task.