Page MenuHomePhabricator

Re-evaluate support for $wgUseCopyrightUpload in social tools
Open, Needs TriagePublic

Description

By the "virtue" of being ugly copy-pasta of each other, all Social-Tools which have uploading special pages implement support for $wgUseCopyrightUpload in their upload pages. $wgUseCopyrightUpload is false by default, but setting it to true causes E_NOTICEs about undefined properties, like these:

Notice: Undefined property: SpecialUploadAvatar::$mUploadCopyStatus in /var/www/html/mediawiki 1.31.0/extensions/SocialProfile/UserProfile/includes/specials/SpecialUploadAvatar.php on line 170
Notice: Undefined property: SpecialUploadAvatar::$mUploadSource in /var/www/html/mediawiki-1.31.0/extensions/SocialProfile/UserProfile/includes/specials/SpecialUploadAvatar.php on line 174

Nevermind that, since those are very easy to fix. The real problem here is that while $wgUseCopyrightUpload is a decent feature and it makes perfect sense for the core Special:Upload page and maybe even for SocialProfile's Special:UploadAvatar page...there's no backend support whatsoever for storing the user-supplied copyright and source metadata.

Affected extensions and their special pages: