Page MenuHomePhabricator

Warning "Toolgroups must have a 'name' property"
Closed, ResolvedPublic

Description

When viewing action=edit (example), the console contained the following warning:

Toolgroups must have a 'name' property
> OO.ui.warnDeprecation
>> 	OO.ui.Toolbar.setup

Which comes from the following ve-init code:

switchToolbar.setup( [ {
		type: 'list',
		icon: 'edit',
		title: mw.msg( 'visualeditor-mweditmode-tooltip' ),
		include: [ 'editModeVisual', 'editModeSource' ]
} ] );

Event Timeline

Krinkle created this task.Jul 2 2018, 3:35 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 2 2018, 3:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle updated the task description. (Show Details)Jul 2 2018, 3:35 AM

Change 443617 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix toolbar group names

https://gerrit.wikimedia.org/r/443617

Change 443619 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Fix toolbar group names

https://gerrit.wikimedia.org/r/443619

Change 443617 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix toolbar group names

https://gerrit.wikimedia.org/r/443617

Change 443619 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix toolbar group names

https://gerrit.wikimedia.org/r/443619

Deskana closed this task as Resolved.Jul 13 2018, 9:55 AM
Deskana triaged this task as Medium priority.