Page MenuHomePhabricator

Cache API requests pulling CommonsHelper2 configuration files
Open, Stalled, Needs TriagePublic

Description

Currently, the configuration files are requested for every single import. A caching layer with sensible defaults needs to be added, e.g. 1 to 5 minutes.

An ideal solution would be a caching layer that can detect if a configuration file changed, and only then pulls it again.

Event Timeline

thiemowmde changed the task status from Open to Stalled.May 19 2020, 7:39 AM

Note we are not aware of a need to even do this. We are tracking the number of imports already. The moment we see these numbers going up significantly, we might need to come back and implement the caching suggested here. Otherwise it's not worth investing time on this, especially because it comes with side effects that can affect the user experience (uploads done very fast might use outdated config pages, and we don't yet know how to avoid this, other than requesting the config page every time).