Consider refactoring the CollapseTable transform of the page library so that the event handling is outside of the transform function, so that the DOM transformations can be run server-side, while the event handling can be done separately on the client side.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mobile-html spec: CollapseTables is not included for now | mediawiki/services/mobileapps | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T169242 Develop Page Content Service for Reading Clients | |||
| Resolved | None | T177425 Develop General Layer of PCS | |||
| Resolved | None | T177433 Develop HTML Content API to be used with companion structured JSON APIs | |||
| Resolved | • bearND | T170584 Evaluate and Integrate page library transforms into PCS | |||
| Declined | • bearND | T198667 Split up CollapseTable transform into client and server side code |
Event Timeline
Comment Actions
@bearND, the CollapseTableTransform was more or less copied from the Android / iOS apps with a whole of bunch tests added on top. There was a lot and still is a lot of code that could use some love :] Please feel free to be aggressive when refactoring it!
Comment Actions
Put it on doing since it is a subtask of the task you are doing and you are assigned. If you want someone to pick it up and help with it, move it back to todo and unassign yourself from it ✊
Comment Actions
I'm not sure whether PCS should be running this transform, even if we split up a portion that could run server-side. This seems like a UI decision and would go counter to us providing more content vs UI. It would also require some I18N on the server for three labels (infobox/other table label, footer label), or at least run a bigger portion of this transform on the client.
Comment Actions
Change 449457 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] mobile-html spec: CollapseTables is not included for now
Comment Actions
Change 449457 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] mobile-html spec: CollapseTables is not included for now