Page MenuHomePhabricator

Form grammatical features: Form field labels not connected
Closed, ResolvedPublic

Description

The HTML form field labels for forms' grammatical features are not connected to the inputs they represent. They should using the for attribute.

GIVEN I am on the lexeme page
WHEN  adding a new form to the lexeme
AND   adding a grammatical feature to that form
THEN  the grammatical feature form field is connected to its respective label "Grammatical features"

Possible synergies with T198702

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 3 2018, 12:11 PM
Pablo-WMDE updated the task description. (Show Details)Jul 3 2018, 12:11 PM
Lydia_Pintscher triaged this task as Low priority.Jan 4 2019, 10:13 AM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.
toan claimed this task.Wed, May 13, 9:52 AM
toan moved this task from ready to go to in progress on the Wikidata board.
Pablo-WMDE updated the task description. (Show Details)Wed, May 13, 1:28 PM

Change 596245 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/WikibaseLexeme@master] GrammaticalFeatureView: labels not connected to input

https://gerrit.wikimedia.org/r/596245

Change 596245 abandoned by Tobias Andersson:
GrammaticalFeatureView: labels not connected to input

Reason:
Lots of unnecessary patches that does not make sense in the end.

https://gerrit.wikimedia.org/r/596245

Change 596434 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/WikibaseLexeme@master] GrammaticalFeatureView: labels not connected to input

https://gerrit.wikimedia.org/r/596434

Change 596434 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] GrammaticalFeatureView: labels not connected to input

https://gerrit.wikimedia.org/r/596434

WMDE-leszek closed this task as Resolved.Tue, May 19, 2:50 PM

Looks good, thanks!