Page MenuHomePhabricator

Special:Log/suppress needs better error handling
Closed, ResolvedPublic

Description

When a person without sufficient rights visits [[Special:Log/suppress]], it should give an appropriate error message. Simply showing all logs is bad error handling.


Version: unspecified
Severity: enhancement

Details

Reference
bz17881

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:33 PM
bzimport set Reference to bz17881.
MZMcBride created this task.Mar 9 2009, 9:09 AM

mike.lifeguard+bugs wrote:

(In reply to comment #0)

When a person without sufficient rights visits [[Special:Log/suppress]], it
should give an appropriate error message. Simply showing all logs is bad error
handling.

Presumably the corollary of that is that on Special:Log/suppress we should show as much info as possible (since anyone who can see the suppress log can also see the content that was hidden or whatever) -- see bug 18335.

  • Bug 21519 has been marked as a duplicate of this bug. ***

FT2.wiki wrote:

The supppress log itself is not public or admin visible -- for reference, the old oversight log used to be public then had to be made private too, similar reasons long ago covered.

So a non-oversighter should probably get a message saying they don't have access to this log, as per suggestion.

Change 74580 had a related patch set uploaded by Legoktm:
If a user does not have permission to view a log type, throw a PermissionsError

https://gerrit.wikimedia.org/r/74580

Change 74580 merged by jenkins-bot:
If a user does not have permission to view a log type, throw a PermissionsError

https://gerrit.wikimedia.org/r/74580

Restricted Application added a subscriber: JEumerus. · View Herald TranscriptAug 5 2016, 2:26 PM