Maniphest T198818

Pagebanner positioning doesn't work on RTL wikis
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Af420
	Jul 4 2018, 9:13 PM

Description

Please fix Pagebanner on mobile site in Pashto Wikivoyage. Pashto Wikivoyage shows just half of the picture in banner, but it's just when we have any Arabic language in setting for example Pashto or Persian
For Example: Pagebanner when we display language to Pashto

Screenshot_2018-07-04-23-15-41-1.png (1×1 px, 513 KB)

But when we display language to English or Norwegian it shows everything alright on the same site.
Just like this:

Screenshot_2018-07-04-23-16-51-1.png (1×1 px, 963 KB)

thank you so much.

Acceptance criteria

https://ps.wikivoyage.org/wiki/%D9%82%D8%A8%D8%B1%D8%B3?uselang=en should show the same banner as https://ps.wikivoyage.org/wiki/%D9%82%D8%A8%D8%B1%D8%B3?uselang=ps

Developer notes

The positioning assumes a LTR image.
In a RTL wiki a RTL right image will clip from the left rather than from the right.
Switching the direction of the banner element resolves this

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Banners should display same in RTL or LTR	mediawiki/extensions/WikidataPageBanner	master	+1 -1

Customize query in gerrit

Event Timeline

Af420 created this task.Jul 4 2018, 9:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2018, 9:13 PM

Af420 updated the task description. (Show Details)Jul 4 2018, 9:28 PM

Restricted Application added subscribers: jeblad, jhsoby. · View Herald TranscriptJul 4 2018, 9:28 PM

Kizule added a project: Mobile.Jul 4 2018, 9:39 PM

Hi @Baloch007, thanks for taking the time to report this!
Unfortunately this report lacks some information. If you have time and can still reproduce the problem: Please add a more complete description to this report.
That can be a clear list of specific steps to reproduce the situation, providing a link to the website in the screenshots where the issue can be seen.
You can edit the task description by clicking Edit Task.
Ideally, exact and clear steps to reproduce should allow any other person to follow these steps (without having to interpret those steps) and see the same results. Problems that others can reliably reproduce can get fixed faster. Thanks!

This looks like a right-to-left issue, but we'll need to know the image in question to fix.
At very least, I need to know the URL and image you used for the banner as since I am not familiar with the Pashto language I can't read the title in the banner.

The code in the wikipage should look something like this:

{{PAGEBANNER:Grand_canyon.jpg}}

It looks like Pashto is not using WikidataPageBanner as evidenced by the 2 titles on https://ps.wikivoyage.org/wiki/%D9%82%D8%A8%D8%B1%D8%B3 so much more context needed before we can look at this!

Looking forward to your reply!

Restricted Application added a project: I18n. · View Herald TranscriptJul 10 2018, 9:16 PM

In T198818#4413978, @Jdlrobson wrote:
This looks like a right-to-left issue, but we'll need to know the image in question to fix.
At very least, I need to know the URL and image you used for the banner as since I am not familiar with the Pashto language I can't read the title in the banner.

The code in the wikipage should look something like this:
{{PAGEBANNER:Grand_canyon.jpg}}
It looks like Pashto is not using WikidataPageBanner as evidenced by the 2 titles on https://ps.wikivoyage.org/wiki/%D9%82%D8%A8%D8%B1%D8%B3 so much more context needed before we can look at this!

Looking forward to your reply!

@Herald have a look at the same link now: https://ps.wikivoyage.org/wiki/%D9%82%D8%A8%D8%B1%D8%B3 :-)

Jdlrobson renamed this task from Please fix Pagebanner on PsWikivoyage to Pagebanner positioning doesn't work on RTL wikis.Jul 11 2018, 7:04 PM

Jdlrobson changed the task status from Stalled to Open.

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited projects, added Web-Team-Backlog-Archived, Wikidata-Page-Banner; removed Local-Wiki-Template-And-Gadget-Issues, Web-Team-Backlog-Archived (Tracking).

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 11 2018, 7:05 PM

Change 445239 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikidataPageBanner@master] Use margin-right rather than margin-left on RTL wikis

https://gerrit.wikimedia.org/r/445239

gerritbot added a project: Patch-For-Review.Jul 11 2018, 7:05 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Jul 11 2018, 7:41 PM

Jdlrobson updated the task description. (Show Details)

Change 445239 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Banners should display same in RTL or LTR

https://gerrit.wikimedia.org/r/445239

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 11 2018, 11:00 PM

@Baloch007 could you please confirm this is working as expected on our test server?:
https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=en
https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=ps

Yes it's correct :-)

In T198818#4417946, @Jdlrobson wrote:

@Baloch007 could you please confirm this is working as expected on our test server?:
https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=en
https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=ps

@Jdlrobson Yes it's correct :-)

Thanks for confirming! This will be deployed in 1.32.wmf.13 currently planned for July 17th (https://wikitech.wikimedia.org/wiki/Deployments)

MBinder_WMF moved this task from Triaged but Future to Readers-Web-Kanbanana-Board-2018-19-Q1 on the Web-Team-Backlog-Archived board.Aug 23 2018, 12:00 AM

MBinder_WMF edited projects, added Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog-Archived.

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 23 2018, 12:00 AM

	F23326618: Screenshot_2018-07-04-23-16-51-1.png
	Jul 4 2018, 9:28 PM

	F23326490: Screenshot_2018-07-04-23-15-41-1.png
	Jul 4 2018, 9:28 PM

Pagebanner positioning doesn't work on RTL wikisClosed, ResolvedPublicActions